From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/4] gnu: Add irrlicht.
Date: Sun, 16 Nov 2014 18:30:41 +0100
Message-ID: <874mtzf3y6.fsf@gnu.org>
References: <87ioifqgta.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	<87fvdjqgrw.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	<87d28nqgqw.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32956)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Xq3ez-0001s8-JD
	for guix-devel@gnu.org; Sun, 16 Nov 2014 12:30:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Xq3et-0004ed-KO
	for guix-devel@gnu.org; Sun, 16 Nov 2014 12:30:49 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:57941)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Xq3et-0004eZ-5u
	for guix-devel@gnu.org; Sun, 16 Nov 2014 12:30:43 -0500
In-Reply-To: <87d28nqgqw.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	(David Thompson's message of "Sun, 16 Nov 2014 10:58:47 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

David Thompson <dthompson2@worcester.edu> skribis:

> From 2eac67986d62e8d81857a7148421ab79d327f3e1 Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Fri, 5 Sep 2014 13:16:50 -0400
> Subject: [PATCH 2/4] gnu: Add irrlicht.
>
> * gnu/packages/games.scm (irrlicht): New variable.

[...]

> +              (uri (string-append
> +                    "mirror://sourceforge/irrlicht/Irrlicht%20SDK/"
> +                    (string-join (take (string-split version #\.) 2) ".")

Please use =E2=80=98version-major+minor=E2=80=99.

> +    (description
> +     "The Irrlicht Engine is a high performance realtime 3D engine writt=
en in
> +C++.")

Could you expound a little bit?  :-)

> +    (license zlib)))

=E2=80=98zlib=E2=80=99 here refers to the <package>, not to the <license>. =
 You probably
need to a #:prefix in the import and rename references to the licenses.

Thanks,
Ludo=E2=80=99.