From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomas Cech Subject: Re: [PATCH v3] gnu: Add bullet. Date: Fri, 12 Dec 2014 08:08:18 +0100 Message-ID: <874mt11h25.wl%tcech@suse.cz> References: <1418336516-27971-1-git-send-email-sleep_walker@suse.cz> <87a92tftst.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzKKl-0004sB-7Q for guix-devel@gnu.org; Fri, 12 Dec 2014 02:08:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzKKg-00048u-Cu for guix-devel@gnu.org; Fri, 12 Dec 2014 02:08:15 -0500 Received: from cantor2.suse.de ([195.135.220.15]:41191 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzKKg-00048V-7E for guix-devel@gnu.org; Fri, 12 Dec 2014 02:08:10 -0500 In-Reply-To: <87a92tftst.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: David Thompson Cc: guix-devel@gnu.org Thanks again for your review. At Thu, 11 Dec 2014 22:09:22 -0500, David Thompson wrote: >=20 > Hello again, >=20 > Missed one thing during my previous review. >=20 > Tom=E1=B9 =C8ech writes: >=20 > > * gnu/packages/game-development.scm: New file > > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. > > --- > > gnu-system.am | 1 + > > gnu/packages/game-development.scm | 43 +++++++++++++++++++++++++++++++= ++++++++ > > 2 files changed, 44 insertions(+) > > create mode 100644 gnu/packages/game-development.scm > > > > diff --git a/gnu-system.am b/gnu-system.am > > index e923340..481a9a7 100644 > > --- a/gnu-system.am > > +++ b/gnu-system.am > > @@ -95,6 +95,7 @@ GNU_SYSTEM_MODULES =3D \ > > gnu/packages/freeipmi.scm \ > > gnu/packages/ftp.scm \ > > gnu/packages/fribidi.scm \ > > + gnu/packages/game-development.scm \ > > gnu/packages/games.scm \ > > gnu/packages/gawk.scm \ > > gnu/packages/gcal.scm \ > > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-deve= lopment.scm > > new file mode 100644 > > index 0000000..72e73dd > > --- /dev/null > > +++ b/gnu/packages/game-development.scm > > @@ -0,0 +1,43 @@ > [snip] > > +(define-public bullet > > + (package > > + (name "bullet") > > + (version "2.82") > > + (source (origin > > + (method url-fetch) > > + (uri (string-append "https://bullet.googlecode.com/files= /bullet-" > > + version "-r2704.tgz")) >=20 > I remember there being some discussion about dashes in version numbers, > and I can't remember the outcome. If there's no issue, I think that the > "-r2704" should be part of the version number string. I'm pretty sure that this version is generally refered as '2.82' only, even= on their own pages: http://bulletphysics.org/wordpress/?p=3D393. Gentoo has 2.82: http://packages.gentoo.org/package/sci-physics/bullet Debian is referring to that as 2.82-r2704: https://packages.debian.org/source/sid/misc/bullet openSUSE is not relevant as I made that package :b Thanks, S_W