Re: [PATCH 1/2] gnu: Add vte.

[David Thompson <dthompson2@worcester.edu>]

宋文武 <iyzsong@gmail.com> writes:

> * gnu/packages/gnome.scm (vte, vte-0): New variables.
> ---
>  gnu/packages/gnome.scm | 57 +++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 56 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 5d84f4e..7087727 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -47,7 +47,8 @@
>    #:use-module (gnu packages gl)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages xorg)
> -  #:use-module (gnu packages xdisorg))
> +  #:use-module (gnu packages xdisorg)
> +  #:use-module (gnu packages ncurses))
>  
>  (define-public brasero
>    (package
> @@ -1324,3 +1325,57 @@ language features to GNOME developers without imposing any additional runtime
>  requirements and without using a different ABI compared to applications and
>  libraries written in C.")
>      (license license:lgpl2.1+)))
> +
> +(define-public vte
> +  (package
> +    (name "vte")
> +    (version "0.38.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnome/sources/" name "/"
> +                                  (version-major+minor version) "/"
> +                                  name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "1rbxrigff9yszbgdw0gw4c2saz4d1hbbpz21phzxx14w49wvmnmj"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("intltool" ,intltool)
> +       ("vala" ,vala)
> +       ("gobject-introspection" ,gobject-introspection)
> +       ("glib" ,glib "bin") ; for glib-genmarshal, etc.
> +       ("xmllint" ,libxml2)))
> +    (propagated-inputs
> +     `(("gtk+" ,gtk+))) ; required by libvte-2.91.pc
> +    (home-page "http://www.gnome.org/")
> +    (synopsis "Virtual Terminal Emulator")
> +    (description
> +     "VTE is a library (libvte) implementing a terminal emulator widget for
> +GTK+, and a minimal sample application (vte) using that.  Vte is mainly used in
> +gnome-terminal, but can also be used to embed a console/terminal in games,
> +editors, IDEs, etc.")
> +    (license license:lgpl2.1+)))
> +
> +;; stable version for gtk2, required by xfce4-terminal.
> +(define-public vte-0

Maybe call this one 'vte-gtk2'?  'vte-0' isn't very descriptive.

> +  (package (inherit vte)
> +    (name "vte")
> +    (version "0.28.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnome/sources/" name "/"
> +                                  (version-major+minor version) "/"
> +                                  name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "1bmhahkf8wdsra9whd3k5l5z4rv7r58ksr8mshzajgq2ma0hpkw6"))))
> +    (arguments
> +     '(#:configure-flags '("--disable-python")))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("intltool" ,intltool)
> +       ("glib" ,glib "bin")))   ; for glib-genmarshal, etc.
> +    (propagated-inputs
> +     `(("gtk+" ,gtk+-2)         ; required by libvte.pc
> +       ("ncurses" ,ncurses))))) ; required by libvte.la
> -- 
> 2.1.2
>
>

Looks good otherwise!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate