From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH]: Add CUPS. Date: Mon, 05 Jan 2015 16:35:57 +0100 Message-ID: <874ms5qlya.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y89hM-0005Gn-Ra for guix-devel@gnu.org; Mon, 05 Jan 2015 10:36:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y89hH-0000qs-SD for guix-devel@gnu.org; Mon, 05 Jan 2015 10:36:04 -0500 Received: from hera.aquilenet.fr ([2a01:474::1]:55712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y89hH-0000qY-LK for guix-devel@gnu.org; Mon, 05 Jan 2015 10:35:59 -0500 In-Reply-To: (Ricardo Wurmus's message of "Mon, 5 Jan 2015 14:04:04 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel Ricardo Wurmus skribis: > There are a couple of problems with this package, one of which is that > the test suite is failing for some reason. I have not been able to > figure out why the "cupsFileFind" test fails, so I disabled the tests. OK. Do you have any more details from the test suite log? > I'm also not sure if creating two outputs "out" and "include" is > correct. To build OpenJDK with IcedTea I need to have both the library > output and the include files and after splitting the outputs this worked > fine. The reason for splitting would be if it turns out that the include directory takes a fair amount of space that is not needed in many cases. If that=E2=80=99s the case, then splitting makes sense. That may w= ell be the case: what=E2=80=99s the side of each of these outputs? If it=E2=80=99s just that it happens to fix OpenJDK as a side effect, that= =E2=80=99s not a good reason. :-) > Finally, I have not actually tried to use CUPS at all, because I only > really need the libs and headers to build OpenJDK. OK but that=E2=80=99ll be useful eventually to get Evince and friends to pr= int correctly. > + (license license:gpl2+))) Isn=E2=80=99t it GPLv2-only? The rest looks good to me. Thanks, Ludo=E2=80=99.