From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add support for the 'armhf-linux' system
Date: Wed, 07 Jan 2015 20:45:58 +0100
Message-ID: <874ms22x3d.fsf@gnu.org>
References: <87y4pezd6w.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50655)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Y8wYP-0003T1-RQ
	for guix-devel@gnu.org; Wed, 07 Jan 2015 14:46:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Y8wYK-00073e-VF
	for guix-devel@gnu.org; Wed, 07 Jan 2015 14:46:05 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:59644)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Y8wYK-00073V-OJ
	for guix-devel@gnu.org; Wed, 07 Jan 2015 14:46:00 -0500
In-Reply-To: <87y4pezd6w.fsf@netris.org> (Mark H. Weaver's message of "Wed, 07
	Jan 2015 12:57:11 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

Mark H Weaver <mhw@netris.org> skribis:

> From 4a9d9c327b501b43c96cb42859329a7d1a9520b5 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Wed, 31 Dec 2014 04:23:12 -0500
> Subject: [PATCH] gnu: Add support for the 'armhf-linux' system.
>
> Based on preliminary work by John Darrington <john@darrington.wattle.id.a=
u>.
>
> * gnu/packages/bootstrap/armhf-linux/bash,
>   gnu/packages/bootstrap/armhf-linux/mkdir,
>   gnu/packages/bootstrap/armhf-linux/tar,
>   gnu/packages/bootstrap/armhf-linux/xz: New files.
>
> * gnu-system.am (bootstrap_armhf_linuxdir, dist_bootstrap_armhf_linux_DAT=
A)
>   (nodist_bootstrap_armhf_linux_DATA): New variables.
>   (DISTCLEANFILES): Add $(nodist_bootstrap_armhf_linux_DATA).
>   (gnu/packages/bootstrap/armhf-linux/guile-2.0.11.tar.xz): New target.
> * build-aux/download.scm (file-name->uri): Use newer date in URI for
>   armhf-linux.
> * gnu/packages/bootstrap.scm (raw-build): Use "guile-2.0.11.tar.xz" on
>   armhf-linux.
>   (glibc-dynamic-linker, %bootstrap-coreutils&co, %bootstrap-binutils)
>   (%bootstrap-glibc, %bootstrap-gcc): Add armhf-linux cases.
> * .gitignore: Add gnu/packages/bootstrap/armhf-linux/guile-2.0.11.tar.xz.

No need to log .gitignore changes.

> * gnu/packages/gcc.scm (gcc-configure-flags-for-triplet): Add armhf case.
>   (gcc-4.7)[pre-configure]: Add gcc/config/*/linux-eabi.h to the list
>   of files in which to patch GLIBC_DYNAMIC_LINKER.
>
> * gnu/packages/cross-base.scm (xgcc-armhf): New variable.
> * guix/utils.scm (gnu-triplet->nix-system, nix-system->gnu-triplet):
>   Add armhf cases.
>
> * m4/guix.m4 (GUIX_SYSTEM_TYPE): Add armhf case.
>   (GUIX_ASSERT_SUPPORTED_SYSTEM): Add armhf-linux to list of
>   supported systems.
> * doc/guix.texi (GNU Distribution): Add armhf-linux to the list of
>   supported systems.

This looks perfect!

One request: could you make the gcc.scm, cross-base.scm, and utils.scm
changes a separate patch, since they constitute the first logical step?

Thanks a lot for all the work!

Ludo=E2=80=99.