From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] gnu: Add ngircd. Date: Sun, 01 Feb 2015 01:58:18 -0500 Message-ID: <874mr6f791.fsf@netris.org> References: <87sieqr574.fsf@taylan.uni.cx> <87k302qz8h.fsf@taylan.uni.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHoUF-0004NM-Uz for guix-devel@gnu.org; Sun, 01 Feb 2015 01:58:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHoUB-0000w3-Tu for guix-devel@gnu.org; Sun, 01 Feb 2015 01:58:27 -0500 Received: from world.peace.net ([50.252.239.5]:57721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHoUB-0000vz-O4 for guix-devel@gnu.org; Sun, 01 Feb 2015 01:58:23 -0500 In-Reply-To: <87k302qz8h.fsf@taylan.uni.cx> ("Taylan Ulrich \=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\= message of "Sun, 01 Feb 2015 00:58:22 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Taylan Ulrich =?utf-8?Q?=22Bay=C4=B1rl=C4=B1?= =?utf-8?Q?=2FKammer=22?= Cc: guix-devel@gnu.org taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") writes: > From 444dc72eff46ceb343fcdfdfc368390417201002 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Taylan=3D20Ulrich=3D20Bay=3DC4=3DB1rl=3DC4=3DB1/Kammer?= =3D > > Date: Sat, 31 Jan 2015 22:03:25 +0100 > Subject: [PATCH] gnu: Add ngircd. > > * gnu-system.am (GNU_SYSTEM_MODULES): Add ngircd.scm. > * gnu/packages/ngircd.scm: New file. > --- > gnu-system.am | 1 + > gnu/packages/ngircd.scm | 61 +++++++++++++++++++++++++++++++++++++++++++= ++++++ > 2 files changed, 62 insertions(+) > create mode 100644 gnu/packages/ngircd.scm How about adding this package to messaging.scm instead? > diff --git a/gnu/packages/ngircd.scm b/gnu/packages/ngircd.scm > new file mode 100644 > index 0000000..4636df5 > --- /dev/null > +++ b/gnu/packages/ngircd.scm > @@ -0,0 +1,61 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright =C2=A9 2014 Taylan Ulrich Bay=C4=B1rl=C4=B1/Kammer It's 2015 :) > +;;; > +;;; This file is part of GNU Guix. > +;;; > +;;; GNU Guix is free software; you can redistribute it and/or modify it > +;;; under the terms of the GNU General Public License as published by > +;;; the Free Software Foundation; either version 3 of the License, or (at > +;;; your option) any later version. > +;;; > +;;; GNU Guix is distributed in the hope that it will be useful, but > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +;;; GNU General Public License for more details. > +;;; > +;;; You should have received a copy of the GNU General Public License > +;;; along with GNU Guix. If not, see . > + > +(define-module (gnu packages ngircd) > + #:use-module ((guix licenses) #:prefix l:) > + #:use-module (guix packages) > + #:use-module (guix download) > + #:use-module (guix build-system gnu) > + #:use-module (gnu packages gnutls) > + #:use-module (gnu packages compression)) > + > +(define-public ngircd > + (package > + (name "ngircd") > + (version "22") > + (source (origin > + (method url-fetch) > + (uri (string-append "http://arthur.barton.de/pub/ngircd/ng= ircd-" > + version ".tar.xz")) > + (sha256 > + (base32 > + "17k3g9qd9d010czk5846qxvzkmw4fihv8l6m2a2287crbxm3xhd4"))= )) > + (build-system gnu-build-system) > + ;; XXX Add more inputs to enable more features, e.g. IDENT, libiconv. > + (inputs `(("zlib" ,zlib) > + ("gnutls" ,gnutls))) > + (arguments > + `(#:configure-flags > + `("--with-gnutls" "--enable-ipv6") > + #:phases > + ;; Necessary for the test suite, should it be enabled in the futu= re. > + (alist-cons-after > + 'configure 'post-configure > + (lambda _ > + (substitute* "src/ngircd/Makefile" > + (("#!/bin/sh") (which "sh")))) This substitution will remove the "#!", which we want to keep. > + %standard-phases) > + ;; Test-suite inflates our dependencies with e.g. expect(1). > + #:tests? #f)) I think it would be good to enable the test suite if possible. Adding 'expect' as an input is not a problem. Can you try it and see if you run into other serious difficulties? > + (home-page "http://ngircd.barton.de/") > + (synopsis "Lightweight Internet Relay Chat server for small networks= ") > + (description > + "ngIRCd is a lightweight Internet Relay Chat server for small or pr= ivate > +networks. It is easy to configure, can cope with dynamic IP addresses, = and > +supports IPv6, SSL-protected connections as well as PAM for authenticati= on.") > + (license l:gpl2+))) Otherwise looks good to me. Can you send an updated patch? Thanks! Mark