From: Mark H Weaver <mhw@netris.org>
To: "Taylan Ulrich \"Bayırlı/Kammer\"" <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add ngircd.
Date: Sun, 01 Feb 2015 01:58:18 -0500 [thread overview]
Message-ID: <874mr6f791.fsf@netris.org> (raw)
In-Reply-To: <87k302qz8h.fsf@taylan.uni.cx> ("Taylan Ulrich \=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\= message of "Sun, 01 Feb 2015 00:58:22 +0100")
taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") writes:
> From 444dc72eff46ceb343fcdfdfc368390417201002 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
> <taylanbayirli@gmail.com>
> Date: Sat, 31 Jan 2015 22:03:25 +0100
> Subject: [PATCH] gnu: Add ngircd.
>
> * gnu-system.am (GNU_SYSTEM_MODULES): Add ngircd.scm.
> * gnu/packages/ngircd.scm: New file.
> ---
> gnu-system.am | 1 +
> gnu/packages/ngircd.scm | 61 +++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 62 insertions(+)
> create mode 100644 gnu/packages/ngircd.scm
How about adding this package to messaging.scm instead?
> diff --git a/gnu/packages/ngircd.scm b/gnu/packages/ngircd.scm
> new file mode 100644
> index 0000000..4636df5
> --- /dev/null
> +++ b/gnu/packages/ngircd.scm
> @@ -0,0 +1,61 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2014 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
It's 2015 :)
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages ngircd)
> + #:use-module ((guix licenses) #:prefix l:)
> + #:use-module (guix packages)
> + #:use-module (guix download)
> + #:use-module (guix build-system gnu)
> + #:use-module (gnu packages gnutls)
> + #:use-module (gnu packages compression))
> +
> +(define-public ngircd
> + (package
> + (name "ngircd")
> + (version "22")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "http://arthur.barton.de/pub/ngircd/ngircd-"
> + version ".tar.xz"))
> + (sha256
> + (base32
> + "17k3g9qd9d010czk5846qxvzkmw4fihv8l6m2a2287crbxm3xhd4"))))
> + (build-system gnu-build-system)
> + ;; XXX Add more inputs to enable more features, e.g. IDENT, libiconv.
> + (inputs `(("zlib" ,zlib)
> + ("gnutls" ,gnutls)))
> + (arguments
> + `(#:configure-flags
> + `("--with-gnutls" "--enable-ipv6")
> + #:phases
> + ;; Necessary for the test suite, should it be enabled in the future.
> + (alist-cons-after
> + 'configure 'post-configure
> + (lambda _
> + (substitute* "src/ngircd/Makefile"
> + (("#!/bin/sh") (which "sh"))))
This substitution will remove the "#!", which we want to keep.
> + %standard-phases)
> + ;; Test-suite inflates our dependencies with e.g. expect(1).
> + #:tests? #f))
I think it would be good to enable the test suite if possible. Adding
'expect' as an input is not a problem. Can you try it and see if you
run into other serious difficulties?
> + (home-page "http://ngircd.barton.de/")
> + (synopsis "Lightweight Internet Relay Chat server for small networks")
> + (description
> + "ngIRCd is a lightweight Internet Relay Chat server for small or private
> +networks. It is easy to configure, can cope with dynamic IP addresses, and
> +supports IPv6, SSL-protected connections as well as PAM for authentication.")
> + (license l:gpl2+)))
Otherwise looks good to me. Can you send an updated patch?
Thanks!
Mark
next prev parent reply other threads:[~2015-02-01 6:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 21:49 [PATCH] gnu: Add ngircd "Taylan Ulrich Bayırlı/Kammer"
2015-01-31 23:58 ` Taylan Ulrich Bayırlı/Kammer
2015-02-01 6:58 ` Mark H Weaver [this message]
2015-02-01 23:23 ` Taylan Ulrich Bayırlı/Kammer
2015-02-05 12:46 ` Ludovic Courtès
2015-02-05 14:32 ` Taylan Ulrich Bayırlı/Kammer
2015-02-05 15:46 ` Mark H Weaver
2015-02-05 11:53 ` Taylan Ulrich Bayırlı/Kammer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mr6f791.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=taylanbayirli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.