From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH]: Add Ant.
Date: Thu, 05 Feb 2015 13:32:14 +0100 [thread overview]
Message-ID: <874mr05yk1.fsf@gnu.org> (raw)
In-Reply-To: <idjlhkkdzlx.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Fri, 30 Jan 2015 17:04:10 +0100")
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
> this patch adds ant-minimal, a minimal configuration of Apache Ant. Ant
> can be configured with lots of optional libraries, but since most of
> these libraries are built with Ant, I think it makes sense to provide a
> minimal version.
Yes.
> A wart is that Ant (even in the minimal configuration) depends on
> hamcrest-core, which can only be built with Ant. The good news is that
> it appears that hamcrest-core is only used for running the tests after
> Ant is built.
What you did (referring to hamcrest-core.jar) is fine. Turning off
tests in ant-minimal would also be fine, IMO; perhaps even preferable,
since that avoids another pre-build binary. WDYT?
> I used the gnu-build-system instead of the trivial-build-system, because
> using the trivial-build-system required me to write a lot more code in
> order to unpack the tarball, patch shebangs, add tools to the PATH,
> etc. Using the gnu-build-system I only had to remove a few phases to
> make it work. Maybe we need a somewhat more powerful version of the
> trivial-build-system.
Makes sense.
> From a8cf4bbd4a8147215a84f27e4aa6247163b4fdf4 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Fri, 30 Jan 2015 16:57:13 +0100
> Subject: [PATCH] gnu: Add Ant.
>
> * gnu/packages/java.scm (ant-minimal): New variable.
> ---
> gnu/packages/java.scm | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 4a86f63..46ff798 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -48,6 +48,54 @@
> #:use-module (gnu packages zip)
> #:use-module (gnu packages texinfo))
>
> +(define-public ant-minimal
> + (package
> + (name "ant")
s/ant/ant-minimal/
Perhaps it could additionally be made private, because users will have
no reason to use the minimal variant, no?
> + (description
> + "Ant is a platform-independent build tool for Java.")
Could you expound a bit, saying it’s similar to ‘make’, has build
recipes written in XML, is especially convenient for Java projects,
etc.?
I’ll reply to your other comments.
Thanks,
Ludo’.
prev parent reply other threads:[~2015-02-05 12:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 16:04 [PATCH]: Add Ant Ricardo Wurmus
2015-01-30 16:21 ` Ricardo Wurmus
2015-02-05 12:34 ` Ludovic Courtès
2015-02-06 15:51 ` Ricardo Wurmus
2015-02-07 22:55 ` Ludovic Courtès
2015-02-09 14:51 ` Ricardo Wurmus
2015-02-15 15:40 ` Andreas Enge
2015-02-15 16:13 ` Ricardo Wurmus
2015-02-15 16:21 ` Andreas Enge
2015-02-16 16:38 ` Ricardo Wurmus
2015-02-16 17:08 ` Andreas Enge
2015-02-05 12:32 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mr05yk1.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.