From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu: Add gnugo. Date: Thu, 19 Feb 2015 20:04:57 +0300 Message-ID: <874mqh6ddy.fsf@gmail.com> References: <1424354241-31310-1-git-send-email-david.hashe@dhashe.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOUXB-0003Hi-TL for guix-devel@gnu.org; Thu, 19 Feb 2015 12:05:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOUX7-00043N-70 for guix-devel@gnu.org; Thu, 19 Feb 2015 12:05:05 -0500 Received: from mail-la0-x229.google.com ([2a00:1450:4010:c03::229]:44799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOUX6-000430-VU for guix-devel@gnu.org; Thu, 19 Feb 2015 12:05:01 -0500 Received: by lams18 with SMTP id s18so813103lam.11 for ; Thu, 19 Feb 2015 09:04:59 -0800 (PST) In-Reply-To: <1424354241-31310-1-git-send-email-david.hashe@dhashe.com> (David Hashe's message of "Thu, 19 Feb 2015 07:57:21 -0600") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: David Hashe Cc: guix-devel@gnu.org Hello, I didn't try the patch, but I have a couple of notes. David Hashe (2015-02-19 16:57 +0300) wrote: > --- > gnu-system.am | 1 + > gnu/packages/gnugo.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 45 insertions(+) > create mode 100644 gnu/packages/gnugo.scm > > diff --git a/gnu-system.am b/gnu-system.am > index eeadd8f..723a00c 100644 > --- a/gnu-system.am > +++ b/gnu-system.am > @@ -122,6 +122,7 @@ GNU_SYSTEM_MODULES =3D \ > gnu/packages/global.scm \ > gnu/packages/gnome.scm \ > gnu/packages/gnunet.scm \ > + gnu/packages/gnugo.scm \ Alphabetically it should be above gnunet.scm. [...] > + (build-system gnu-build-system) > + (inputs `(("readline" , readline) > + ("texinfo", texinfo))) Should be: =E2=80=9C("readline" ,readline)=E2=80=9D and =E2=80=9C("texinfo"= ,texinfo)=E2=80=9D (without spaces after the commas) > + (synopsis "Go game") > + (description "GNU Go is a program that plays the game of Go, in whic= h players place stones on a grid to form territory or capture other stones.= While it can be played directly from the terminal, rendered in ASCII char= acters, it is also possible to play GNU Go with 3rd party graphical interfa= ces or even in Emacs. It supports the standard game storage format (SGF, S= mart Game Format) and inter-process communication format (GMP, Go Modem Pro= tocol)") Please, wrap the description to 72-78 chars (some people even make 80 chars per line) and add a period at the end of the final sentence. Also you may test it with "guix lint gnugo". > + (home-page "http://www.gnu.org/software/gnugo/") > + (license gpl3+))) --=20 Alex