From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?5a6L5paH5q2m?= Subject: Re: [PATCH 4/5] gnu: Add emotion-generic-players Date: Thu, 26 Feb 2015 20:47:20 +0800 Message-ID: <874mq8hmav.fsf@gmail.com> References: <1424910673-17665-1-git-send-email-sleep_walker@suse.cz> <1424910673-17665-4-git-send-email-sleep_walker@suse.cz> <20150226102308.GA3600@debian.math.u-bordeaux1.fr> <20150226111443.GB10407@venom> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49543) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQxqX-0005Ef-9f for guix-devel@gnu.org; Thu, 26 Feb 2015 07:47:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQxqR-00085Z-WD for guix-devel@gnu.org; Thu, 26 Feb 2015 07:47:17 -0500 Received: from mail-pa0-x22b.google.com ([2607:f8b0:400e:c03::22b]:33819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQxqR-00084J-Oq for guix-devel@gnu.org; Thu, 26 Feb 2015 07:47:11 -0500 Received: by pabrd3 with SMTP id rd3so13787721pab.1 for ; Thu, 26 Feb 2015 04:47:11 -0800 (PST) In-Reply-To: <20150226111443.GB10407@venom> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= , Andreas Enge Cc: guix-devel@gnu.org Tom=C3=A1=C5=A1 =C4=8Cech writes: > Hello, > > thanks for review. > > On Thu, Feb 26, 2015 at 11:23:27AM +0100, Andreas Enge wrote: >>Hello, >> >>just a quick comment on the descriptions. It would be good to write full >>sentences, for instance: >> >>On Thu, Feb 26, 2015 at 01:31:12AM +0100, Tom=C3=A1=C5=A1 =C4=8Cech wrote: >>> + "Set of generic media players allowing to open video files throug= h emotion. Useful only for emotion library based applications.") >> >>"Emotion Generic Players provides/consists of/is a set of generic ... >>It is useful only for ...". > > I agree that sentences may be better, I only suck at it. I'll try > to improvide it or I can accept any recommendations in the meantime. > >>I think it would also be good to expand a bit where possible, and to intr= oduce >>the word "enlightenment" in each of these packages (by replacing "EFL" wi= th >>"Enlightenment Foundation Libraries", > > I do agree that use of "Enlightenment Foundation Libraries" instead of > "EFL" could make it more enjoyable to read, but we could expand also > Gimp toolkit, Tool Command Language, ... > > Those who would need such these packages will know and it won't help > to others anyway. > > Synopsis of efl package will show you "Enlightenment Foundation Libraries= ". > >>for instance, or adding a sentence like >>"It is part of the Enlightenment desktop environment"). > > Enlightenment is using the same libraries (they were developed for > Enlightenment) but the libraries are much more generic. It's like > relationship between Qt and KDE, only with reversed history order. > >>Maybe call the file enlightenment.scm? > > I believe efl.scm is more accurate as the packages there would be EFL > based but not necessarily Enlightenment related. Sorry, I didn't notice this line. (for my comment about terminology). Yes, this make sense. But I think it's more clear to make packages from enlightenment.org go into enlightenment.scm, while packages not from enlightenment.org but based on EFL into seperated files.