From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Subject: Re: [PATCH 3/3] gnu: Add MariaDB.
Date: Fri, 17 Apr 2015 21:02:42 +0800
Message-ID: <874moelxfx.fsf@gmail.com>
References: <1429255498-32458-1-git-send-email-iyzsong@gmail.com>
	<1429255498-32458-3-git-send-email-iyzsong@gmail.com>
	<87bninargs.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39016)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1Yj5uZ-0008Vy-Dg
	for guix-devel@gnu.org; Fri, 17 Apr 2015 09:02:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1Yj5uT-0006GG-KN
	for guix-devel@gnu.org; Fri, 17 Apr 2015 09:02:23 -0400
In-Reply-To: <87bninargs.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:
>
>> * gnu/packages/database.scm (mariadb): New variable.
>
> +s: =E2=80=9Cdatabases.scm=E2=80=9D
>
>> +        'configure 'pre-configure
>> +        (lambda _
>> +          (setenv "CONFIG_SHELL" (which "sh"))
>> +          ;; XXX: libstdc++.so lacks RUNPATH for libgcc_s.so.
>> +          (setenv "LDFLAGS" "-lgcc_s")
>
> Indeed, but this is normally compensated by the fact that our GCC
> automatically passed -Wl,-rpath=3D$gcclibdir, no?  What error where you
> getting without it?
Without this flag, all binaries are broken (they linked with
libstdc++.so but with libgcc_s.so not found).
>
>> +             ;; Install testing data to the 'test' output.
>> +             (mkdir-p test)
>> +             (system* "mv" (string-append out "/data")       test)
>> +             (system* "mv" (string-append out "/mysql-test") test)
>> +             (system* "mv" (string-append out "/sql-bench")  test)))
>
> Could you use =E2=80=98rename-file=E2=80=99?
It seem that those are assumed to be installed with the same
basedir as mariadb, and I failed to trick it to run.

I'd like to remove those test data (and the 'test' output).
>
> Otherwise LGTM.
>
> Thanks,
> Ludo=E2=80=99.