From: Mathieu Lirzin <mthl@openmailbox.org>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: Add guix install command
Date: Fri, 07 Aug 2015 12:08:26 +0200 [thread overview]
Message-ID: <874mkb9zs5.fsf@openmailbox.org> (raw)
In-Reply-To: <87614rsfpn.fsf@gmail.com> (Alex Kost's message of "Fri, 07 Aug 2015 10:47:00 +0300")
Alex Kost <alezost@gmail.com> writes:
> Andy Wingo (2015-08-05 12:36 +0300) wrote:
>[...]
>> Attached is a patch to implement "guix install". It just copies over
>> functionality from guix package. We could refactor more but I would
>> start with this as it is; when things need changes is the time to
>> refactor, at least for me. What do you think? :)
[...]
> I just think that refactoring needs to be done instead of copying
> pieces from (guix scripts package).
AIUI doing a "good" refactoring job will imply a lot of code moving
because It means separating the interfaces from the functionalities.
IMO that could be left to next iterations. However, IIUC this patch
could be lighter by using indirections to the 'guix-package' procedure
fornow instead of copying chunks of code. Is that what you mean?
--
Mathieu Lirzin
next prev parent reply other threads:[~2015-08-07 10:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 9:36 Add guix install command Andy Wingo
2015-08-06 21:08 ` Mathieu Lirzin
2015-08-07 7:47 ` Alex Kost
2015-08-07 8:45 ` Andy Wingo
2015-08-07 19:22 ` Alex Kost
2015-08-07 8:48 ` Ricardo Wurmus
2015-08-07 12:01 ` Andy Wingo
2015-08-07 12:22 ` Thompson, David
2015-08-07 12:36 ` Andy Wingo
2015-08-07 16:52 ` Chris Marusich
2015-08-18 16:08 ` Ludovic Courtès
2015-08-18 16:23 ` Ludovic Courtès
2015-08-18 17:10 ` Chris Marusich
2015-08-07 10:08 ` Mathieu Lirzin [this message]
2015-08-07 19:22 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mkb9zs5.fsf@openmailbox.org \
--to=mthl@openmailbox.org \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.