[PATCH] gnu: Add file-roller.

[PATCH] gnu: Add file-roller.

[David Thompson]

[-- Attachment #1: Type: text/plain, Size: 54 bytes --]

Been missing this program for awhile, so here it is!


[-- Attachment #2: 0001-gnu-Add-file-roller.patch --]
[-- Type: text/x-patch, Size: 2271 bytes --]

From 241f44af6ba5229c6fdeda0fadd50345f4abaf60 Mon Sep 17 00:00:00 2001
From: David Thompson <dthompson2@worcester.edu>
Date: Sat, 19 Sep 2015 19:20:52 -0400
Subject: [PATCH] gnu: Add file-roller.

* gnu/packages/gnome.scm (file-roller): New variable.
---
 gnu/packages/gnome.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index ca75fa8..43c918a 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -10,6 +10,7 @@
 ;;; Copyright © 2015 David Hashe <david.hashe@dhashe.com>
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2015 David Thompson <davet@gnu.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3500,3 +3501,36 @@ manage, and publish documentation for Yelp and the web.  Most of the heavy
 lifting is done by packages like yelp-xsl and itstool.  This package just
 wraps things up in a developer-friendly way.")
     (license license:gpl2+)))
+
+(define-public file-roller
+  (package
+    (name "file-roller")
+    (version "3.10.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://gnome/sources/" name "/"
+                                  (version-major+minor version) "/"
+                                  name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "04sg4yzz4c3hzgxhbgx2dc36lq5hjrnrmal2q0amfvhl0jcvp2fq"))))
+    (build-system glib-or-gtk-build-system)
+    (native-inputs
+     `(("intltool" ,intltool)
+       ("pkg-config" ,pkg-config)))
+    ;; TODO: Add libnautilus.
+    (inputs
+     `(("gtk+" ,gtk+)
+       ("gdk-pixbuf" ,gdk-pixbuf)
+       ("json-glib" ,json-glib)
+       ("libarchive" ,libarchive)
+       ("libnotify" ,libnotify)
+       ("nettle" ,nettle)))
+    (propagated-inputs
+     `(("itstool" ,itstool)
+       ("xmllint" ,libxml2)))
+    (synopsis "Graphical archive manager for GNOME")
+    (description "File Roller is an archive manager for the GNOME desktop
+environment.")
+    (home-page "http://fileroller.sourceforge.net/")
+    (license license:gpl2+)))
-- 
2.5.0


[-- Attachment #3: Type: text/plain, Size: 38 bytes --]


-- 
David Thompson
GPG Key: 0FF1D807

Re: [PATCH] gnu: Add file-roller.

[Ricardo Wurmus]

Looks good to me!

I have one question about the propagated inputs, though: why are they
needed?  Is it obvious (and I just fail to see it), or could you explain
this in a comment?

~~ Ricardo

Re: [PATCH] gnu: Add file-roller.

[Ludovic Courtès]

David Thompson <dthompson2@worcester.edu> skribis:

> +    (description "File Roller is an archive manager for the GNOME desktop
> +environment.")

In addition to Ricardo’s comment, could you expound on this a little
bit?  I’m not completely sure what it means to manage archives.  :-)

Ludo’.

Re: [PATCH] gnu: Add file-roller.

[Thompson, David]

On Sun, Sep 20, 2015 at 11:34 AM, Ricardo Wurmus <rekado@elephly.net> wrote:
> Looks good to me!
>
> I have one question about the propagated inputs, though: why are they
> needed?  Is it obvious (and I just fail to see it), or could you explain
> this in a comment?

I noticed that the inputs were propagated in another package, so I monkey typed.

- Dave

Re: [PATCH] gnu: Add file-roller.

[Thompson, David]

On Sun, Sep 20, 2015 at 12:54 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> David Thompson <dthompson2@worcester.edu> skribis:
>
>> +    (description "File Roller is an archive manager for the GNOME desktop
>> +environment.")
>
> In addition to Ricardo’s comment, could you expound on this a little
> bit?  I’m not completely sure what it means to manage archives.  :-)

I moved the propagated inputs to inputs, changed the description to this:

    File Roller is an archive manager for the GNOME desktop
    environment that allows users to view, unpack, and create
    compressed archives such as gzip tarballs.

And pushed.  Thanks!

- Dave