ludo@gnu.org (Ludovic Courtès) writes:

> Mathieu Lirzin <mthl@openmailbox.org> skribis:
>
>> diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
>> index b0427f7..0adb3bf 100644
>> --- a/guix/scripts/lint.scm
>> +++ b/guix/scripts/lint.scm
>> @@ -146,11 +146,11 @@ monad."
>>    (define (check-texinfo-markup description)
>>      "Check that DESCRIPTION can be parsed as a Texinfo fragment.  If the
>>  markup is valid return a plain-text version of DESCRIPTION, otherwise #f."
>> -    (catch 'parser-error
>> -      (lambda () (texi->plain-text description))
>> -      (lambda (keys . args)
>> -        (emit-warning package (_ "Texinfo markup in description is invalid"))
>> -        #f)))
>> +    (unless (false-if-exception (texi->plain-text description))
>> +      (emit-warning package
>> +                    (_ "Texinfo markup in description is invalid")
>> +                    'description)
>> +      #f))
>
> In general, it’s best to avoid ‘false-if-exception’ because it’s too
> coarse-grain.  Here it’s probably OK though, because we want to catch
> any error that may occur in during the conversion.  So this patch is OK
> (with appropriate commit log.)

Ok, thanks for the explanation.