From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/3] gnu: Add c-ares.
Date: Tue, 03 Nov 2015 14:42:20 +0100
Message-ID: <874mh3yzb7.fsf@gnu.org>
References: <1446448523-27811-1-git-send-email-efraim@flashner.co.il>
	<1446448523-27811-2-git-send-email-efraim@flashner.co.il>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40428)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Ztbr1-0001JI-B2
	for guix-devel@gnu.org; Tue, 03 Nov 2015 08:42:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Ztbqx-0006or-2n
	for guix-devel@gnu.org; Tue, 03 Nov 2015 08:42:27 -0500
In-Reply-To: <1446448523-27811-2-git-send-email-efraim@flashner.co.il> (Efraim
	Flashner's message of "Mon, 2 Nov 2015 09:15:21 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

Efraim Flashner <efraim@flashner.co.il> skribis:

> * gnu/packages/aria2.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

[...]

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/bagder/c-ares/archive/cares-"
> +                    (string-map (lambda (c) (if (char=3D? c #\.) #\_ c))=
 version)
> +                    ".tar.gz"))

Please use the standalone tarball from
http://c-ares.haxx.se/download/c-ares-1.10.0.tar.gz and remove the
autotools from =E2=80=98native-inputs=E2=80=99 and the modified phases.

> +    (license license:x11)))

There=E2=80=99s no top-level license file, but the license text in source f=
iles
is:

   * Permission to use, copy, modify, and distribute this
   * software and its documentation for any purpose and without
   * fee is hereby granted, provided that the above copyright
   * notice appear in all copies and that both that copyright
   * notice and this permission notice appear in supporting
   * documentation, and that the name of M.I.T. not be used in
   * advertising or publicity pertaining to distribution of the
   * software without specific, written prior permission.
   * M.I.T. makes no representations about the suitability of
   * this software for any purpose.  It is provided "as is"
   * without express or implied warranty.

This is neither <http://directory.fsf.org/wiki/License:Expat> nor
<http://directory.fsf.org/wiki/License:X11>.

Unless someone has a better idea, I would make it:

  (license:x11-style "http://c-ares.haxx.se/license.html")

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.