From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] doc: Fix 'geiser-guile-load-path' example. Date: Tue, 17 Nov 2015 20:22:29 +0300 Message-ID: <874mgksfqi.fsf@gmail.com> References: <87k2pkl8a6.fsf@gmail.com> <87y4dztb1g.fsf@gnu.org> <87egfp1282.fsf@gmail.com> <877flg7g92.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zyjxi-00018g-2R for guix-devel@gnu.org; Tue, 17 Nov 2015 12:22:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zyjxe-0000fT-WC for guix-devel@gnu.org; Tue, 17 Nov 2015 12:22:34 -0500 In-Reply-To: <877flg7g92.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 17 Nov 2015 17:16:57 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s (2015-11-17 19:16 +0300) wrote: > Alex Kost skribis: > >> Ludovic Court=C3=A8s (2015-11-15 20:41 +0300) wrote: >> >>> Alex Kost skribis: >>> >>>> (add-to-list 'geiser-guile-load-path 'foo) errors if "geiser-guile.el" >>>> is not loaded yet, so I think it's better to put it inside >>>> 'with-eval-after-load', WDYT? >>> >>> Sounds good. I guess that=E2=80=99s because (require 'guix-init) doesn= =E2=80=99t >>> require 'geiser? >> >> "guix-init.el" shouldn't require geiser. IMO it should load as less >> code as possible, because it will increase the Emacs start time. >> >> In general I think requiring/loading packages is evil (as it slows down >> starting Emacs), so I avoid 'require'-s when possible in my init file. > > Agreed, I was just making sure I understood the issue at hand. OK. Actually I thought that you use 'with-eval-after-load' or 'eval-after-load' or 'use-package', and you just didn't mention it in the manual because it's a common Emacs thing. But it looks like you use a straightforward (add-to-list ...), which can work only if "geiser-guile.el" is already loaded. Out of curiosity, do you somehow load the whole geiser in your emacs config? If so, why? I mean not just (require 'geiser), as it does not load "geiser-guile.el", but maybe (require 'geiser-mode) or something like it. (I personally don't touch 'geiser-guile-load-path' at all, I just set GUILE_LOAD_PATH in my ".bash_profile" instead) > The patch you sent looks good to me then. Thanks! --=20 Alex