From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add python-contextlib2 Date: Mon, 14 Dec 2015 00:16:27 +0100 Message-ID: <874mfmuegk.fsf@gnu.org> References: <564C7549.3070707@uq.edu.au> <87mvu0x4c9.fsf@gnu.org> <87d1ujw8mc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8FsX-0001Jp-L5 for guix-devel@gnu.org; Sun, 13 Dec 2015 18:16:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8FsU-0000qn-E0 for guix-devel@gnu.org; Sun, 13 Dec 2015 18:16:33 -0500 In-Reply-To: (Chris Marusich's message of "Mon, 7 Dec 2015 21:14:29 -0800") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Chris Marusich Cc: "guix-devel@gnu.org" Chris Marusich skribis: > On 12/6/15, Ludovic Court=C3=A8s wrote: >> Yes, could you adjust it and send an updated patch? >> > > I've attached the new patch here. I've shortened a few lines, > including the one requested. Great. > In particular, I've shortened every line of the description to 70 > columns. Because of that, it looks like the first line of the > description will wind up being significantly shorter than 70 chars. > Are the newlines in the description significant? Or is there some > reformatting that happens when the description is printed to the > terminal, e.g. via "guix package --search=3Dfoo"? Yes, there=E2=80=99s reformatting happening here, so don=E2=80=99t worry. = We normally wrap at 78 columns, as per .dir-locals.el. >> I must I was a bit confused, partly due to the reply-on-top, which made >> it more difficult for me to see what you were referring to. Okay, I was >> also late for other reasons ;-), but still, I think it=E2=80=99d be grea= t if you >> could avoid top-posting. > > Thanks for pointing this out; I'll reply on the bottom from now on! Thanks. :-) > From 4089b10f384b389999576dfc8766c661a5787a4b Mon Sep 17 00:00:00 2001 > From: Chris Marusich > Date: Mon, 7 Dec 2015 21:07:40 -0800 > Subject: [PATCH] gnu: Add python-contextlib2. > > * gnu/packages/python.scm (python-contextlib2, python2-contextlib2): > New variables. [...] > + (home-page "http://contextlib2.readthedocs.org/") > + (synopsis "Tools for decorators and context managers") > + (description "This module is primarily a backport of the Python > +3.2 contextlib to earlier Python versions. Like contextlib, it > +provides utilities for common tasks involving decorators and context > +managers. It also contains additional features that are not part of > +the standard library.") > + (license psfl))) > + > +(define-public python2-contextlib2 > + (package-with-python2 python-contextlib2)) IIUC the description it only makes sense for Python 2.x, right? In that case, could you add an explicit #:python in =E2=80=98arguments=E2= =80=99 and keep only the 2.x variant? I could do that for you if you prefer. Thanks, and sorry for the delay! Ludo=E2=80=99.