all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add GenomicFeatures.
Date: Fri, 18 Dec 2015 17:26:50 +0100	[thread overview]
Message-ID: <874mfflo39.fsf@gnu.org> (raw)
In-Reply-To: <idj1taj7v2c.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Fri, 18 Dec 2015 14:19:55 +0100")

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> PS: If reviewing these patch sets is uncomfortable in this format and
> you’d prefer separate emails or some other approach, please let me
> know.  I appreciate your reviews a lot!

I have a slight preference for one message per patch, but this works for
me too.

[...]

> +    (synopsis "Options management framework")
> +    (description
> +     "This package provides a scoped options management framework.")

Would be nice to expound a little bit (are we talking about command-line
options?  what does “scoped” mean?).

> +    (home-page "http://cran.r-project.org/web/packages/snow")
> +    (synopsis "Support for simple parallel computing in R")
> +    (description
> +     "This package provides support for simple parallel computing in R.")

Likewise.

Apart from that, it looks good to me!

Ludo’.

  reply	other threads:[~2015-12-18 16:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18 13:19 [PATCH] Add GenomicFeatures Ricardo Wurmus
2015-12-18 16:26 ` Ludovic Courtès [this message]
2016-01-07 16:22   ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mfflo39.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=ricardo.wurmus@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.