From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 4/6] emacs: Replace 'generation-diff' search with 'profile-diff'. Date: Tue, 12 Jan 2016 21:29:54 +0100 Message-ID: <874meibkxp.fsf@gnu.org> References: <1452419630-4399-1-git-send-email-alezost@gmail.com> <1452419630-4399-5-git-send-email-alezost@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJ5Zq-00080H-2z for guix-devel@gnu.org; Tue, 12 Jan 2016 15:30:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJ5Zl-0001uo-3t for guix-devel@gnu.org; Tue, 12 Jan 2016 15:30:02 -0500 In-Reply-To: <1452419630-4399-5-git-send-email-alezost@gmail.com> (Alex Kost's message of "Sun, 10 Jan 2016 12:53:48 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org Alex Kost skribis: > * emacs/guix-main.scm (generation-package-specifications): Rename to... > (profile-package-specifications): ... this. Take a single 'profile' > argument. > (generation-difference): Rename to... > (profile-difference): ... this. Take profiles as arguments. > (package/output-sexps): Adjust accordingly. > * emacs/guix-ui-generation.el (guix-generation-list-profiles-to-compare): > New procedure. > (guix-generation-list-show-added-packages) > (guix-generation-list-show-removed-packages): Use it. > * emacs/guix-messages.el (guix-messages): Replace 'generation-diff' with > 'profile-diff'. > (guix-message-outputs-by-diff): Adjust accordingly. LGTM.