From mboxrd@z Thu Jan 1 00:00:00 1970 From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) Subject: Re: [PATCH] Add nautilus Date: Sun, 07 Feb 2016 09:46:14 +0800 Message-ID: <874mdlz40p.fsf@member.fsf.org> References: <81cb4d87f795011de938341a065bbccb@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSEQz-0000ET-Vo for guix-devel@gnu.org; Sat, 06 Feb 2016 20:46:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSEQw-0006gY-Pm for guix-devel@gnu.org; Sat, 06 Feb 2016 20:46:41 -0500 Received: from smtp26.openmailbox.org ([62.4.1.60]:49662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSEQw-0006gR-K3 for guix-devel@gnu.org; Sat, 06 Feb 2016 20:46:38 -0500 In-Reply-To: <81cb4d87f795011de938341a065bbccb@openmailbox.org> (rennes@openmailbox.org's message of "Mon, 01 Feb 2016 17:51:33 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: rennes@openmailbox.org Cc: guix-devel@gnu.org rennes@openmailbox.org writes: > Hi, > > i attached patch for review. > > Regards > > From 18bddcf21cac4245997a76d4ea5cfc856d1b6157 Mon Sep 17 00:00:00 2001 > From: Rene Saavedra > Date: Mon, 1 Feb 2016 17:45:22 +0100 > Subject: [PATCH] Add nautilus > > --- > gnu/packages/nautilus.scm | 63 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 gnu/packages/nautilus.scm > > diff --git a/gnu/packages/nautilus.scm b/gnu/packages/nautilus.scm > new file mode 100644 > index 0000000..f982f0b > --- /dev/null > +++ b/gnu/packages/nautilus.scm > @@ -0,0 +1,63 @@ > +2016-02-01 Rene Saavedra > + > + * gnu/packages/nautilus.scm: New file. > + * gnu-system (GNU_SYSTEM_MODULES): Add it. Should add to gnome.scm > + > +(define-module (gnu packages nautilus) > + #:use-module ((guix licenses) #:prefix license:) > + #:use-module (guix packages) > + #:use-module (guix download) > + #:use-module (guix build-system gnu) > + #:use-module (guix utils) > + #:use-module (gnu packages freedesktop) > + #:use-module (gnu packages glib) > + #:use-module (gnu packages gnome) > + #:use-module (gnu packages gtk) > + #:use-module (gnu packages photo) > + #:use-module (gnu packages pkg-config) > + #:use-module (gnu packages xml) > + #:use-module (gnu packages xorg)) > +(define-public nautilus > + (package > + (name "nautilus") > + (version "3.18.2") I see the latest stable version is 3.18.5, but that require a newer GTK+ last time I tried. OK here with a comment about it. > + (source > + (origin > + (method url-fetch) > + (uri (string-append "mirror://gnome/sources/" name "/" > + (version-major+minor version) "/" > + name "-" version ".tar.xz")) > + (sha256 > + (base32 > + "0jj23n8vmmyc4gp5xhiz7slsxwksydp26blxi5m154yaw9lgdp38")))) > + (build-system gnu-build-system) I think glib-or-gtk-build-system is needed, GNOME applications usually required gsettings schemas to be run, glib-or-gtk-build-system handles that by wrap the binaries with XDG_DATA_DIRS to find the schemas. You can run nautilus with 'XDG_DATA_DIRS' unset to test. > + (arguments > + `(#:configure-flags > + (list "--disable-tracker" "--disable-packagekit") Please add some comment, eg: XXX: not packaged. > + #:tests? #f)) Add comment why tests is disable, eg: XXX: failed with .... > + (native-inputs > + `(("glib" ,glib "bin") > + ("gobject-introspection" ,gobject-introspection) > + ("intltool" ,intltool) > + ("pkg-config" ,pkg-config))) > + (inputs > + `(("adwaita-icon-theme" ,adwaita-icon-theme) > + ("exempi" ,exempi) > + ("glib" ,glib) > + ("gnome-desktop" ,gnome-desktop) > + ("gsettings-desktop-schemas" ,gsettings-desktop-schemas) > + ("gtk+" ,gtk+) > + ("gvfs" ,gvfs) > + ("libexif" ,libexif) > + ("libnotify" ,libnotify) > + ("libx11" ,libx11) > + ("libxml2" ,libxml2) > + ("pango" ,pango))) > + (home-page "https://wiki.gnome.org/Apps/Nautilus") > + (synopsis "GNOME file manager") > + (description > + "Nautilus is a file manager designed for the GNOME desktop. > +Nautilus design provides the user a simple way and elegant to > +managing files and applications, through simple menus and > +notifications.") > + (license license:gpl2+))) ; libnautilus-extenstions under lgpl