From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Wingo Subject: Re: [PATCH v4] Add hplip Date: Wed, 23 Mar 2016 09:45:05 +0100 Message-ID: <874mbxshv2.fsf@igalia.com> References: <20160312191233.48a661ca@scratchpost.org> <8737ruuj0l.fsf@gnu.org> <20160315210512.23989245@scratchpost.org> <20160315221931.16abe3dc@scratchpost.org> <87vb4mygw4.fsf@igalia.com> <87mvpyyfon.fsf@igalia.com> <20160320011904.50131806@scratchpost.org> <20160321230700.452ca6c1@scratchpost.org> <87r3f2ud9x.fsf@igalia.com> <20160322113001.52af072b@scratchpost.org> <87egb2u6gd.fsf@igalia.com> <20160322201207.790bd384@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aieQI-0004pc-KN for guix-devel@gnu.org; Wed, 23 Mar 2016 04:45:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aieQE-0007Dd-GS for guix-devel@gnu.org; Wed, 23 Mar 2016 04:45:50 -0400 Received: from pb-sasl0.pobox.com ([208.72.237.25]:60982 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aieQE-00078A-8V for guix-devel@gnu.org; Wed, 23 Mar 2016 04:45:46 -0400 In-Reply-To: <20160322201207.790bd384@scratchpost.org> (Danny Milosavljevic's message of "Tue, 22 Mar 2016 20:12:07 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Danny Milosavljevic Cc: guix-devel@gnu.org Hi! Thank you for the quick reactions on the formatting. I know it can be irritating, but in the future things will be much smoother :) Just a couple additional fixes. On Tue 22 Mar 2016 20:12, Danny Milosavljevic writes: > + (build-system gnu-build-system) > + (home-page "http://hplipopensource.com/") > + (synopsis "HP Printer Drivers") > + (description "Hewlett-Packard Printer Drivers and PPDs.") > + (license (list license:gpl2 license:bsd-3)) ; FIXME and which MIT > + ;; FIXME remove proprietary plug-in installer, hp-plugin (plugin.py) > + ;; FIXME PPDs use "hpcups" in cupsFilter. In which directory? > + ;; TODO install apparmor profile files Probably you will need to fix the plug-in installer issue before adding to Guix. For the other ones, the style is to write complete sentences in comments starting with ";;", including "." at the end. > + (arguments > + `(#:configure-flags > + `("--disable-network-build" > + ,(string-append "--prefix=" (assoc-ref %outputs "out")) > + ,(string-append "--sysconfdir=" (assoc-ref %outputs "out") "/etc") > + ;; Disable until mime.types merging works (FIXME) > + "--disable-fax-build" > + ,(string-append "--with-cupsfilterdir=" > + (assoc-ref %outputs "out") > + "/lib/cups/filter") ; TODO merge > + ,(string-append "--with-cupsbackenddir=" > + (assoc-ref %outputs "out") > + "/lib/cups/backend") ; TODO merge > + ,(string-append "--with-icondir=" > + (assoc-ref %outputs "out") > + "/share/applications") ; TODO merge > + ,(string-append "--with-systraydir=" > + (assoc-ref %outputs "out") > + "/etc/xdg")) ; TODO merge With regards to "TODO merge", that is something to be done outside the package -- either in the service, or when building a profile. Please remove these comments and instead be at peace with installing things in #$out :) > + #:phases (modify-phases %standard-phases > + (add-after 'unpack 'fix-libusb > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (substitute* "base/g.py" > + (("'/etc/hp/hplip.conf'") > + (string-append "'" out > + "/etc/hp/hplip.conf" "'"))) Can you re-indent? It should look like this: (substitute* filename ((pattern) substitution)) FWIW, in emacs, the .dir-locals.el should add rules to make C-M-q do this automatically. > + ; Python3 support is available starting from HPLIP-3.15.2 ";;" and a full stop please. Thank you again for your patience! Andy