Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> * pam-services “su”, “sudo”, and possibly “passwd” are not actually
>>   modified when I check their names (as I do in this patch).  If I
>>   extend all pam-services without checking their names they do get
>>   modified.  With the attached patch the pam file for “su” does not get
>>   the pam entry for “pam_limits.so”.
>
> But it works for me!  :-)
>
> I’ve applied the attached patch (fixes a minor syntax issue in the patch
> you sent), and then did:

Oh, yes, I must have sent another version.  Attached is the version I
used.

>
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env guix system build ~/src/configuration/pluto-configuration.scm
> substitute: updating list of substitutes from 'https://mirror.hydra.gnu.org'... 100.0%
> substitute: updating list of substitutes from 'https://hydra.gnu.org'... 100.0%
> La jenaj derivoj estos konstruataj:
>    /gnu/store/0fxwylcmdxy7bqmjpxwqf24v2x4yr53w-system.drv
>    /gnu/store/q254gqx3rgwxn98nsaz16z8rl58nhfkw-shepherd.conf.drv
>    /gnu/store/517cxw8xiniwsh9bfdp389qxlm9w5jj8-activate-service.drv
>    /gnu/store/ky8p3bq0xpj3lf989fz1ba3j2xycyiz6-activate.drv
>    /gnu/store/ljjl4zs722flxbpip8jdssqd549g7pay-boot.drv
>    /gnu/store/vz8745sdk0ph0rykxldwzmfa3a5r7cm1-etc.drv
> /gnu/store/s84hvl064k494174z692wl1vaqzrygln-system
> ludo@pluto ~/src/guix$ grep pam_limit /gnu/store/s84hvl064k494174z692wl1vaqzrygln-system/etc/pam.d/*
> /gnu/store/s84hvl064k494174z692wl1vaqzrygln-system/etc/pam.d/login:session required pam_limits.so conf=/etc/security/limits.conf
> /gnu/store/s84hvl064k494174z692wl1vaqzrygln-system/etc/pam.d/slim:session required pam_limits.so conf=/etc/security/limits.conf
> /gnu/store/s84hvl064k494174z692wl1vaqzrygln-system/etc/pam.d/su:session required pam_limits.so conf=/etc/security/limits.conf
> --8<---------------cut here---------------end--------------->8---
>
> … where the configuration in question has (pam-limits-service) in its
> ‘services’ field.

How odd.  It does not work for me:

--8<---------------cut here---------------start------------->8---
rekado in guix: ./pre-inst-env guix system build /etc/config.scm
substitute: updating list of substitutes from 'https://hydra.gnu.org'... 100.0%
The following derivations will be built:
   /gnu/store/8pldcwijn1szpyc4cbm4z808sbdn18r0-system.drv
   /gnu/store/x2pigxf3mrf5crbmnjfxza8h3a70fvnv-activate-service.drv
   /gnu/store/nwm5gsfavv35g3hjgzi5xymhxhqf2g4l-activate.drv
   /gnu/store/38x73bdqj40wmy3lz8qnpfc20wb0dr6x-boot.drv
   /gnu/store/mlkssjhw4avm8a37yi0nfk4z4zd9bkj6-security.drv
   /gnu/store/1lxncnhdab3l732r144r5ww0y9rjq72f-etc.drv
/gnu/store/qwjbfjzqlbdcrsbnyyjylfkhm6kqna5d-system
rekado in guix: grep limits /gnu/store/qwjbfjzqlbdcrsbnyyjylfkhm6kqna5d-system/etc/pam.d/*
/gnu/store/qwjbfjzqlbdcrsbnyyjylfkhm6kqna5d-system/etc/pam.d/login:session required pam_limits.so conf=/etc/security/limits.conf
/gnu/store/qwjbfjzqlbdcrsbnyyjylfkhm6kqna5d-system/etc/pam.d/slim:session required pam_limits.so conf=/etc/security/limits.conf
--8<---------------cut here---------------end--------------->8---

When my configuration looks like this:

      (services (list (pam-limits-service)))

Then there’s one file containing pam_limits, namely “/etc/pam.d/su”.
When my configuration looks like this, however:

      (services (cons* (pam-limits-service)
                       %desktop-services))

Then only “/etc/pam.d/login” and “/etc/pam.d/slim” contain pam_limits;
“/etc/pam.d/su” does not.

~~ Ricardo