From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add pyusb.
Date: Thu, 07 Apr 2016 22:49:22 +0200 [thread overview]
Message-ID: <874mbdb0vh.fsf@gnu.org> (raw)
In-Reply-To: <87h9foo41b.fsf@elephly.net> (Ricardo Wurmus's message of "Wed, 30 Mar 2016 08:47:44 +0200")
Ricardo Wurmus <rekado@elephly.net> skribis:
> From 2f190da0d812501a4ab3db94a99ac8f7c6698cbc Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Tue, 29 Mar 2016 09:06:09 +0200
> Subject: [PATCH] gnu: Add python-pyusb.
>
> * gnu/packages/libusb.scm (python-pyusb, python2-pyusb): New variables.
[...]
> + (lambda* (#:key inputs #:allow-other-keys)
> + (substitute* "usb/libloader.py"
> + (("lib = locate_library\\(candidates, find_library\\)")
> + (string-append
> + "lib = \""
> + (car (find-files (assoc-ref inputs "libusb")
> + (lambda (file stat)
> + (and ((file-name-predicate
> + "^libusb-.*\\.so\\..*") file stat)
> + (not (symbolic-link? file))))))
Maybe (with SRFI-1):
(find (negate symbolic-link?)
(find-files (assoc-ref inputs "libusb")
"^libusb-.*\\.so\\..*"))
But really this is nitpicking, the patch should go in. :-)
Ludo’.
prev parent reply other threads:[~2016-04-07 20:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 7:07 [PATCH] Add pyusb Ricardo Wurmus
2016-03-30 2:27 ` Eric Bavier
2016-03-30 6:07 ` Ricardo Wurmus
2016-03-30 6:47 ` Ricardo Wurmus
2016-04-07 20:49 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mbdb0vh.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.