From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] New package: Seren Date: Tue, 19 Jul 2016 20:04:40 +0300 Message-ID: <874m7ld0ev.fsf@gmail.com> References: <1462458843.23626.5.camel@gmail.com> <87a8hxki1b.fsf@gmail.com> <1468932716.19774.9.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPYRs-0002PI-Bm for guix-devel@gnu.org; Tue, 19 Jul 2016 13:04:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPYRo-0005IE-4S for guix-devel@gnu.org; Tue, 19 Jul 2016 13:04:47 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:34208) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPYRn-0005I3-N4 for guix-devel@gnu.org; Tue, 19 Jul 2016 13:04:44 -0400 Received: by mail-lf0-x244.google.com with SMTP id l69so1825800lfg.1 for ; Tue, 19 Jul 2016 10:04:43 -0700 (PDT) In-Reply-To: <1468932716.19774.9.camel@gmail.com> (Francesco Frassinelli's message of "Tue, 19 Jul 2016 14:51:56 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Francesco Frassinelli Cc: guix-devel@gnu.org Francesco Frassinelli (2016-07-19 15:51 +0300) wrote: > Il giorno lun, 04/07/2016 alle 09.56 +0300, Alex Kost ha scritto: >> Francesco Frassinelli (2016-05-05 17:34 +0300) wrote: >>=20 >> > I'm a new Guix user and I created a package for Seren, a P2P VoIP >> > conference program which uses Opus as codec. >>=20 >> Ping!=C2=A0=C2=A0Hello again, are you willing to send an updated patch, = putting >> 'seren' in "gnu/packages/telephony.scm" and making other changes >> according to >> ? >>=20 >> Sorry for bothering, your patch is mostly OK, but it would be nice if >> seren was in (gnu packages telephony) module, thanks! > > Hi! Here it is! I wasn't able to test properly due to VM Stack Overflow > error... I'll try to fix my Guix system next week :) Hi! If you have some problems, you can ask for help on . I think you forgot to Cc guix-devel list, so I do it. It's not a problem that you didn't test if it can be built, I'll do it, but... could you send an updated patch? (See the comments below) > From 1d51b625a325f0c9ee20602572b441950801df97 Mon Sep 17 00:00:00 2001 > From: Francesco Frassinelli > Date: Tue, 19 Jul 2016 13:11:48 +0200 > Subject: [PATCH] Add package Seren Not a big deal, but the commit message should be: gnu: Add seren. * gnu/packages/telephony.scm (seren): New variable. > --- > gnu/packages/seren.scm | 65 ++++++++++++++++++++++++++++++++++++++++++++= ++++++ > 1 file changed, 65 insertions(+) > create mode 100644 gnu/packages/seren.scm > > diff --git a/gnu/packages/seren.scm b/gnu/packages/seren.scm > new file mode 100644 > index 0000000..4ebdd07 > --- /dev/null > +++ b/gnu/packages/seren.scm Putting it into (gnu packages telephony) module means to put it into "gnu/packages/telephony.scm" file which already exists. Sorry for not being clear about it. > @@ -0,0 +1,65 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright =C2=A9 2016 Francesco Frassinelli > +;;; > +;;; This file is part of GNU Guix. > +;;; > +;;; GNU Guix is free software; you can redistribute it and/or modify it > +;;; under the terms of the GNU General Public License as published by > +;;; the Free Software Foundation; either version 3 of the License, or (at > +;;; your option) any later version. > +;;; > +;;; GNU Guix is distributed in the hope that it will be useful, but > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +;;; GNU General Public License for more details. > +;;; > +;;; You should have received a copy of the GNU General Public License > +;;; along with GNU Guix. If not, see . > +(define-module (gnu packages telephony) I didn't meant this, see above. In Guile (foo bar baz) module always means that a module file is "<...>/foo/bar/baz.scm". > + #:use-module (guix packages) > + #:use-module (guix download) > + #:use-module (guix build-system gnu) > + #:use-module (guix licenses) > + #:use-module (gnu packages linux) > + #:use-module (gnu packages xiph) > + #:use-module (gnu packages ncurses) > + #:use-module (gnu packages multiprecision)) > + > +(define-public seren > + (package > + (name "seren") > + (version "0.0.21") > + (source (origin > + (method url-fetch) > + (uri (string-append "http://holdenc.altervista.org/" > + "seren/downloads/seren-" version > + ".tar.gz")) > + (sha256 > + (base32 > + "06mams6bng7ib7p2zpfq88kdr4ffril9svzc9lprkb0wjgmkglk9")= ))) > + (build-system gnu-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (arguments `(#:tests? #f))))) No, not arguments inside arguments, this should be simply: (arguments '(#:tests? #f)) ; no "check" target > + (inputs `(("alsa-lib" ,alsa-lib) > + ("opus" ,opus) > + ("libogg" ,libogg) > + ("ncurses" ,ncurses) > + ("gmp" ,gmp))) > + (synopsis "Simple VoIP program to create conferences from the termin= al") > + (description > + "Seren is a simple VoIP program based on the Opus codec that allows= you > +to create a voice conference from the terminal, with up to 10 > +partecipants, without having to register accounts, exchange emails, or > +add people to contact lists. > + > +All you need to join an existing conference is the host name or IP > +address of one of the partecipants. > + > +Seren creates a dynamic peer-to-peer network of equivalent nodes which > +exchange text and audio data using a UDP connection, and offers the > +user the ability to change the quality/bitrate on the fly, encrypt the > +traffic and record the calls.") > + (home-page "http://holdenc.altervista.org/seren/") > + (license gpl3+))) --=20 Alex