all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ng0 <ng0@we.make.ritual.n0.is>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add ircii.
Date: Fri, 05 Aug 2016 10:29:55 +0000	[thread overview]
Message-ID: <874m6zwlss.fsf@we.make.ritual.n0.is> (raw)
In-Reply-To: <87y44bhfvz.fsf@elephly.net>

Ricardo Wurmus <rekado@elephly.net> writes:

> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> Thanks, in the new revision of the patch both issues you two found are
>> fixed.
>
>> +         (replace 'configure
>> +           (lambda* (#:key inputs outputs #:allow-other-keys)
>> +             (let ((out (assoc-ref outputs "out"))
>> +                   (ncurses (assoc-ref inputs "ncurses"))
>> +                   (openssl (assoc-ref inputs "openssl")))
>> +               (setenv "CONFIG_SHELL" (which "bash"))
>> +               (zero?
>> +                (system* "./configure"
>> +                         ;; TODO: find a socks4+5 lib with small size
>> +                         ;; (string-append "--with-socks5=" ghc-socks)
>> +                         (string-append "--prefix=" out)
>> +                         (string-append "--enable-ipv6")
>> +                         (string-append "--with-openssl=" openssl)
>> +                         (string-append "--with-emacs-meta-keys")))))))))
>
> Why is this needed?  Did you try using #:configure-flags instead of
> replacing the configure phase?  You can refer to inputs with
> “%build-inputs” there.
>
> ~~ Ricardo
>

I can try to put it into configure flags, I wrote it like this because
the README suggested it. I'll send a new patch when I'm done with the
gnurl update.

-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org

  reply	other threads:[~2016-08-05 10:30 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01 19:34 [PATCH] gnu: Add ircii ng0
2016-08-02  0:54 ` Leo Famulari
2016-08-02  7:58   ` Andreas Enge
2016-08-02 11:30     ` ng0
2016-08-05  6:46       ` Ricardo Wurmus
2016-08-05 10:29         ` ng0 [this message]
2016-08-05 11:17           ` Ricardo Wurmus
2016-08-05 12:55         ` ng0
2016-08-05 12:57           ` ng0
2016-08-05 13:01           ` ng0
2016-08-05 13:22             ` ng0
2016-08-05 15:48               ` ng0
2016-08-05 15:57                 ` Leo Famulari
2016-08-05 16:11                   ` ng0
2016-08-05 17:55                     ` Leo Famulari
2016-08-05 18:27                       ` ng0
2016-08-05 19:11                         ` Leo Famulari
2016-08-09 19:38             ` Ricardo Wurmus
2016-08-09 19:47               ` Leo Famulari
2016-08-13  7:06                 ` ng0
2016-08-02 12:42   ` 宋文武
2016-08-02 15:19     ` ng0
2016-08-04 19:03       ` ng0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874m6zwlss.fsf@we.make.ritual.n0.is \
    --to=ng0@we.make.ritual.n0.is \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.