From: Jan Nieuwenhuizen <janneke@gnu.org>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 02/11] gnu: Add mingw-w64.
Date: Tue, 09 Aug 2016 17:56:13 +0200 [thread overview]
Message-ID: <874m6uvsv6.fsf@gnu.org> (raw)
In-Reply-To: <87y446cset.fsf@gmail.com> (Alex Kost's message of "Tue, 09 Aug 2016 10:28:42 +0300")
Alex Kost writes:
> Hello, I understand nothing in all this mingw stuff, I just have a couple
> of insignificant comments.
Thanks for looking, they all make sense and I have addressed most.
With MinGW, you can cross build Windows binaries and run them with Wine,
like so
./pre-inst-env guix build --target=i686-w64-mingw32 hello
/gnu/store/5lf701smnkq0wdg91jsyrmf5jnyz6i31-hello-2.10
guix environment --ad-hoc wine -- wine /gnu/store/5lf701smnkq0wdg91jsyrmf5jnyz6i31-hello-2.10/bin/hello.exe
> Jan Nieuwenhuizen (2016-08-09 09:41 +0300) wrote:
>
>> +(define-public mingw-w64
...
>> + (arguments
>> + `(#:configure-flags '("--host=i686-w64-mingw32")
>> + #:phases (modify-phases %standard-phases
>> + (add-before
>> + 'configure 'setenv
>
> The indentation of this 'modify-phases' is not good. I would write it
> like this:
>
> #:phases
> (modify-phases %standard-phases
> (add-before 'configure 'setenv
> (lambda ...)))
Ok.
>> + (lambda _
>> + (let ((xgcc-core (assoc-ref %build-inputs "xgcc-core"))
>
> Here, instead of referring '%build-inputs', it is better (I mean it
> would be more "functional") to use 'inputs' argument passed to this
> phase, like this:
>
> (lambda* (#:key inputs #:allow-other-keys)
> (let ((xgcc-core (assoc-ref inputs "xgcc-core"))
Ok.
Greetings,
Jan
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.nl
next prev parent reply other threads:[~2016-08-09 15:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 6:41 mingw guile.exe cross build patch series v9 Jan Nieuwenhuizen
2016-08-09 6:41 ` [PATCH 01/11] gnu: Add gcc-cross-x86_64 packages for testing Jan Nieuwenhuizen
2016-08-09 6:41 ` [PATCH 02/11] gnu: Add mingw-w64 Jan Nieuwenhuizen
2016-08-09 7:28 ` Alex Kost
2016-08-09 15:56 ` Jan Nieuwenhuizen [this message]
2016-08-10 10:37 ` Alex Kost
2016-08-09 6:41 ` [PATCH 03/11] gnu: cross-build: i686-w64-mingw32: new cross target Jan Nieuwenhuizen
2016-08-09 6:41 ` [PATCH 04/11] gnu: Add function libiconv-if-needed Jan Nieuwenhuizen
2016-08-09 6:41 ` [PATCH 05/11] gnu: libunistring: support mingw: propagate libiconv if needed Jan Nieuwenhuizen
2016-08-09 7:37 ` Alex Kost
2016-08-09 16:00 ` Jan Nieuwenhuizen
2016-08-09 6:41 ` [PATCH 06/11] gnu: gmp: build shared library for mingw Jan Nieuwenhuizen
2016-08-09 6:41 ` [PATCH 07/11] gnu: ncurses: support mingw Jan Nieuwenhuizen
2016-08-09 7:53 ` Alex Kost
2016-08-09 15:59 ` Jan Nieuwenhuizen
2016-08-10 10:47 ` Alex Kost
2016-08-10 13:08 ` Jan Nieuwenhuizen
2016-08-10 18:04 ` Mark H Weaver
2016-08-14 16:54 ` Mark H Weaver
2016-08-15 16:37 ` Jan Nieuwenhuizen
2016-08-16 10:26 ` Ricardo Wurmus
2016-08-16 11:53 ` Guile question ... " Jan Nieuwenhuizen
2016-08-16 18:24 ` Jan Nieuwenhuizen
2016-08-09 6:41 ` [PATCH 08/11] gnu: cross-base: Add cross-libtool Jan Nieuwenhuizen
2016-08-09 8:08 ` Alex Kost
2016-08-09 16:04 ` Jan Nieuwenhuizen
2016-08-10 11:12 ` Alex Kost
2016-08-09 6:41 ` [PATCH 09/11] gnu: libtool: support cross-libtool mingw Jan Nieuwenhuizen
2016-08-09 6:41 ` [PATCH 10/11] gnu: ncurses: build mingw with libtool Jan Nieuwenhuizen
2016-08-09 6:41 ` [PATCH 11/11] gnu: readline: support mingw Jan Nieuwenhuizen
2016-08-09 8:30 ` mingw guile.exe cross build patch series v9 Andy Wingo
2016-08-09 15:41 ` Jan Nieuwenhuizen
2016-08-10 11:03 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m6uvsv6.fsf@gnu.org \
--to=janneke@gnu.org \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.