From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 08/24] gnu: xorg: Add lndir.
Date: Tue, 16 Aug 2016 22:53:49 +0300
Message-ID: <874m6kjxrm.fsf@gmail.com>
References: <20160816183938.22794-1-david@craven.ch>
	<20160816183938.22794-8-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40435)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bZkQs-00007s-0s
	for guix-devel@gnu.org; Tue, 16 Aug 2016 15:53:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bZkQo-0006ZJ-TB
	for guix-devel@gnu.org; Tue, 16 Aug 2016 15:53:54 -0400
Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:33332)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bZkQo-0006Yi-MW
	for guix-devel@gnu.org; Tue, 16 Aug 2016 15:53:50 -0400
Received: by mail-wm0-x241.google.com with SMTP id o80so18207287wme.0
	for <guix-devel@gnu.org>; Tue, 16 Aug 2016 12:53:50 -0700 (PDT)
In-Reply-To: <20160816183938.22794-8-david@craven.ch> (David Craven's message
	of "Tue, 16 Aug 2016 20:39:22 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven (2016-08-16 21:39 +0300) wrote:

> * gnu/packages/xorg.scm (lndir): New variable.

Nice program, I didn't know about it, thanks!

> ---
>  gnu/packages/xorg.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
>
> diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
> index b24e437..1e7da68 100644
> --- a/gnu/packages/xorg.scm
> +++ b/gnu/packages/xorg.scm
> @@ -133,6 +133,31 @@ projects.  Software developers are encouraged to migrate software to the GNU
>  autotools system.")
>      (license license:x11)))
>  
> +(define-public lndir
> +  (package
> +    (name "lndir")
> +    (version "1.0.3")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append
> +                "mirror://xorg/individual/util/lndir-"
> +                version
> +                ".tar.bz2"))

The patch looks good to me, except the indentation of this
(string-append ...).  I usually write 'source' fields like this:

    (source (origin
              (method url-fetch)
              (uri (string-append "mirror://xorg/individual/util/lndir-"
                                  version ".tar.bz2"))
              (sha256
               (base32
                "0pdngiy8zdhsiqx2am75yfcl36l7kd7d7nl0rss8shcdvsqgmx29"))))

But this is not a big deal, of course :-)

> +        (sha256
> +         (base32
> +          "0pdngiy8zdhsiqx2am75yfcl36l7kd7d7nl0rss8shcdvsqgmx29"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("xproto" ,xproto)))
> +    (home-page "http://www.x.org")
> +    (synopsis "Symlink directory into tree")
> +    (description "Create a shadow directory of symbolic links to another
> +directory tree.")
> +    (license license:x11)))
> +
>  (define-public bdftopcf
>    (package
>      (name "bdftopcf")

-- 
Alex