Re: [PATCH 08/24] gnu: xorg: Add lndir.

Re: [PATCH 08/24] gnu: xorg: Add lndir.

[David Craven]

> The patch looks good to me, except the indentation of this
>
> (string-append ...).  I usually write 'source' fields like this:
>
>    (source (origin
>              (method url-fetch)
>              (uri (string-append "mirror://xorg/individual/util/lndir-"
>                                  version ".tar.bz2"))
>              (sha256
>               (base32
>                "0pdngiy8zdhsiqx2am75yfcl36l7kd7d7nl0rss8shcdvsqgmx29"))))
>
> But this is not a big deal, of course :-)

I prefer
(uri (string-append
        "mirror://xorg/individual/util/"
        "lndir-" version ".tar.bz2"))

But in this case I thought that keeping consistent with how it was
done in the xorg.scm file was more important than my preference. What
do you think?

Re: [PATCH 08/24] gnu: xorg: Add lndir.

[Alex Kost]

David Craven (2016-08-17 11:35 +0300) wrote:

>> The patch looks good to me, except the indentation of this
>>
>> (string-append ...).  I usually write 'source' fields like this:
>>
>>    (source (origin
>>              (method url-fetch)
>>              (uri (string-append "mirror://xorg/individual/util/lndir-"
>>                                  version ".tar.bz2"))
>>              (sha256
>>               (base32
>>                "0pdngiy8zdhsiqx2am75yfcl36l7kd7d7nl0rss8shcdvsqgmx29"))))
>>
>> But this is not a big deal, of course :-)
>
> I prefer
> (uri (string-append
>         "mirror://xorg/individual/util/"
>         "lndir-" version ".tar.bz2"))

OK, but then it should be (note the indentation of 'string-append'):

  (uri (string-append
        "mirror://xorg/individual/util/"
        "lndir-" version ".tar.bz2"))

> But in this case I thought that keeping consistent with how it was
> done in the xorg.scm file was more important than my preference. What
> do you think?

Many (probably most) packages in xorg.scm have bad indentation.

-- 
Alex

[PATCH 01/24] gnu: qt: Add qtquickcontrols.

[David Craven]

* gnu/packages/qt.scm (qtquickcontrols): New variable.
---
 gnu/packages/qt.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index a12c526..ca777dd 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -802,6 +802,23 @@ developers using C++ or QML, a CSS & JavaScript like language.")
     (inputs
      `(("qtbase" ,qtbase)))))
 
+(define-public qtquickcontrols
+  (package (inherit qtsvg)
+    (name "qtquickcontrols")
+    (version "5.6.1-1")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "https://download.qt.io/official_releases/qt/"
+                                 (version-major+minor version) "/" version
+                                 "/submodules/" name "-opensource-src-"
+                                 version ".tar.xz"))
+             (sha256
+              (base32
+               "0cjzf844r7wi32ssc9vbw1a2m9hnr8c0i1p7yyljy962ifplf401"))))
+    (inputs
+     `(("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)))))
+
 (define-public python-sip
   (package
     (name "python-sip")
-- 
2.9.0

[PATCH 08/24] gnu: xorg: Add lndir.

[David Craven]

* gnu/packages/xorg.scm (lndir): New variable.
---
 gnu/packages/xorg.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index b24e437..1e7da68 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -133,6 +133,31 @@ projects.  Software developers are encouraged to migrate software to the GNU
 autotools system.")
     (license license:x11)))
 
+(define-public lndir
+  (package
+    (name "lndir")
+    (version "1.0.3")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append
+                "mirror://xorg/individual/util/lndir-"
+                version
+                ".tar.bz2"))
+        (sha256
+         (base32
+          "0pdngiy8zdhsiqx2am75yfcl36l7kd7d7nl0rss8shcdvsqgmx29"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("xproto" ,xproto)))
+    (home-page "http://www.x.org")
+    (synopsis "Symlink directory into tree")
+    (description "Create a shadow directory of symbolic links to another
+directory tree.")
+    (license license:x11)))
+
 (define-public bdftopcf
   (package
     (name "bdftopcf")
-- 
2.9.0

Re: [PATCH 08/24] gnu: xorg: Add lndir.

[Alex Kost]

David Craven (2016-08-16 21:39 +0300) wrote:

> * gnu/packages/xorg.scm (lndir): New variable.

Nice program, I didn't know about it, thanks!

> ---
>  gnu/packages/xorg.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
>
> diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
> index b24e437..1e7da68 100644
> --- a/gnu/packages/xorg.scm
> +++ b/gnu/packages/xorg.scm
> @@ -133,6 +133,31 @@ projects.  Software developers are encouraged to migrate software to the GNU
>  autotools system.")
>      (license license:x11)))
>  
> +(define-public lndir
> +  (package
> +    (name "lndir")
> +    (version "1.0.3")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append
> +                "mirror://xorg/individual/util/lndir-"
> +                version
> +                ".tar.bz2"))

The patch looks good to me, except the indentation of this
(string-append ...).  I usually write 'source' fields like this:

    (source (origin
              (method url-fetch)
              (uri (string-append "mirror://xorg/individual/util/lndir-"
                                  version ".tar.bz2"))
              (sha256
               (base32
                "0pdngiy8zdhsiqx2am75yfcl36l7kd7d7nl0rss8shcdvsqgmx29"))))

But this is not a big deal, of course :-)

> +        (sha256
> +         (base32
> +          "0pdngiy8zdhsiqx2am75yfcl36l7kd7d7nl0rss8shcdvsqgmx29"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("xproto" ,xproto)))
> +    (home-page "http://www.x.org")
> +    (synopsis "Symlink directory into tree")
> +    (description "Create a shadow directory of symbolic links to another
> +directory tree.")
> +    (license license:x11)))
> +
>  (define-public bdftopcf
>    (package
>      (name "bdftopcf")

-- 
Alex