From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 08/24] gnu: xorg: Add lndir.
Date: Wed, 17 Aug 2016 20:49:22 +0300
Message-ID: <874m6js2u5.fsf@gmail.com>
References: <CAL1_imnjJM_+=26_GT49VLC0E-gQLGYxj=+BsPNG52U31Ji-oQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54862)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ba4xz-0005vz-IL
	for guix-devel@gnu.org; Wed, 17 Aug 2016 13:49:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ba4xv-0006BW-5x
	for guix-devel@gnu.org; Wed, 17 Aug 2016 13:49:26 -0400
Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:36276)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ba4xv-0006BR-1n
	for guix-devel@gnu.org; Wed, 17 Aug 2016 13:49:23 -0400
Received: by mail-qk0-x241.google.com with SMTP id v123so10742907qkh.3
	for <guix-devel@gnu.org>; Wed, 17 Aug 2016 10:49:22 -0700 (PDT)
In-Reply-To: <CAL1_imnjJM_+=26_GT49VLC0E-gQLGYxj=+BsPNG52U31Ji-oQ@mail.gmail.com>
	(David Craven's message of "Wed, 17 Aug 2016 10:35:38 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel <guix-devel@gnu.org>

David Craven (2016-08-17 11:35 +0300) wrote:

>> The patch looks good to me, except the indentation of this
>>
>> (string-append ...).  I usually write 'source' fields like this:
>>
>>    (source (origin
>>              (method url-fetch)
>>              (uri (string-append "mirror://xorg/individual/util/lndir-"
>>                                  version ".tar.bz2"))
>>              (sha256
>>               (base32
>>                "0pdngiy8zdhsiqx2am75yfcl36l7kd7d7nl0rss8shcdvsqgmx29"))))
>>
>> But this is not a big deal, of course :-)
>
> I prefer
> (uri (string-append
>         "mirror://xorg/individual/util/"
>         "lndir-" version ".tar.bz2"))

OK, but then it should be (note the indentation of 'string-append'):

  (uri (string-append
        "mirror://xorg/individual/util/"
        "lndir-" version ".tar.bz2"))

> But in this case I thought that keeping consistent with how it was
> done in the xorg.scm file was more important than my preference. What
> do you think?

Many (probably most) packages in xorg.scm have bad indentation.

-- 
Alex