all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: 宋文武 <iyzsong@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/5] profiles: gtk-icon-themes: Use 'gtk-update-icon-cache' from 'gtk+:bin'.
Date: Fri, 19 Aug 2016 03:15:39 -0400	[thread overview]
Message-ID: <874m6hut44.fsf@netris.org> (raw)
In-Reply-To: <20160806104616.13089-2-iyzsong@gmail.com> ("宋文武"'s message of "Sat, 6 Aug 2016 18:46:13 +0800")

宋文武 <iyzsong@gmail.com> writes:

> * guix/profiles.scm (gtk-icon-themes): Use 'gtk-update-icon-cacnhe' from
> the "bin" output of gtk+ package.
> ---
>  guix/profiles.scm | 21 +++++++++++++++------
>  1 file changed, 15 insertions(+), 6 deletions(-)
>
> diff --git a/guix/profiles.scm b/guix/profiles.scm
> index db807a8..9c2dbba 100644
> --- a/guix/profiles.scm
> +++ b/guix/profiles.scm
> @@ -642,7 +642,18 @@ MANIFEST.  Single-file bundles are required by programs such as Git and Lynx."
>  (define (gtk-icon-themes manifest)
>    "Return a derivation that unions all icon themes from manifest entries and
>  creates the GTK+ 'icon-theme.cache' file for each theme."
> -  (mlet %store-monad ((gtk+ (manifest-lookup-package manifest "gtk+")))
> +  (define gtk+  ; lazy reference
> +    (module-ref (resolve-interface '(gnu packages gtk)) 'gtk+))
> +
> +  (mlet %store-monad ((%gtk+ (manifest-lookup-package manifest "gtk+"))
> +                      ;; XXX: Can't use gtk-update-icon-cache corresponding
> +                      ;; to the gtk+ referenced by 'manifest'.  Because
> +                      ;; '%gtk+' can be either a package or store path, and
> +                      ;; there's no way to get the "bin" output for the later.
> +                      (gtk-update-icon-cache
> +                       -> #~(string-append #+gtk+:bin
> +                                           "/bin/gtk-update-icon-cache")))

Hmm.  Would this cause 'gtk+' to become a dependency for building any
profile, even if it contains no graphical programs?

      Mark

  parent reply	other threads:[~2016-08-19  7:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-06 10:46 [PATCH 1/5] gnu: gtk+: Add "bin" output 宋文武
2016-08-06 10:46 ` [PATCH 2/5] profiles: gtk-icon-themes: Use 'gtk-update-icon-cache' from 'gtk+:bin' 宋文武
2016-08-14  2:17   ` Leo Famulari
2016-08-19  7:15   ` Mark H Weaver [this message]
2016-08-20  2:43     ` 宋文武
2016-08-20 18:56       ` Mark H Weaver
2016-08-06 10:46 ` [PATCH 3/5] gnu: evince: Don't install 'icon-theme.cache' 宋文武
2016-08-06 10:46 ` [PATCH 4/5] gnu: gnome-icon-theme, adwaita-icon-theme: " 宋文武
2016-08-14  2:15   ` Leo Famulari
2016-08-14  6:23     ` 宋文武
2016-08-06 10:46 ` [PATCH 5/5] gnu: gnome-themes-standard: " 宋文武
2016-08-14  2:21 ` [PATCH 1/5] gnu: gtk+: Add "bin" output Leo Famulari
2016-08-14  2:51   ` Eric Bavier
2016-08-14  6:21     ` 宋文武
2016-08-23 12:11 ` 宋文武
2016-08-29 15:56 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874m6hut44.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=guix-devel@gnu.org \
    --cc=iyzsong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.