From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH 11/13] gnu: vlc: Fix regression caused by update to qt 5.7.
Date: Sun, 21 Aug 2016 16:10:04 -0400
Message-ID: <874m6ddgtf.fsf@netris.org>
References: <20160820215957.GA6502@jasmine>
	<20160821140825.13048-1-david@craven.ch>
	<20160821140825.13048-11-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51635)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bbZ5b-0004sp-Mb
	for guix-devel@gnu.org; Sun, 21 Aug 2016 16:11:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bbZ5V-0006EG-Lv
	for guix-devel@gnu.org; Sun, 21 Aug 2016 16:11:26 -0400
Received: from world.peace.net ([50.252.239.5]:41654)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bbZ5V-0006EB-IB
	for guix-devel@gnu.org; Sun, 21 Aug 2016 16:11:21 -0400
In-Reply-To: <20160821140825.13048-11-david@craven.ch> (David Craven's message
	of "Sun, 21 Aug 2016 16:08:24 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> writes:
> * gnu/packages/video.scm (vlc)[inputs]: Use qt 5.6.1-1. Add libinput and libxi.

The summary line is a bit misleading, because it leads me to guess that
this commit gets vlc working with Qt 5.7.  Better to write "gnu: vlc:
Use Qt 5.6.1."

Is it necessary to add 'libinput' and 'libxi' to fix this regression, or
is that an unrelated change to add new features?  If the latter, please
add those in a separate commit.

> @@ -635,7 +638,7 @@ audio/video codec library.")
>         ("perl" ,perl)
>         ("pulseaudio" ,pulseaudio)
>         ("python" ,python-wrapper)
> -       ("qtbase" ,qtbase)
> +       ("qtbase" ,qt)

Please change the string to "qt" as well.

      Thanks,
        Mark