From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 9/9] gnu: Add weston.
Date: Sat, 03 Sep 2016 15:29:50 +0200
Message-ID: <874m5xnmb5.fsf@gnu.org>
References: <20160901155711.7388-1-david@craven.ch>
	<20160901155711.7388-9-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55603)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bgB1D-00088b-Ni
	for guix-devel@gnu.org; Sat, 03 Sep 2016 09:30:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bgB18-0000Vu-LK
	for guix-devel@gnu.org; Sat, 03 Sep 2016 09:29:58 -0400
In-Reply-To: <20160901155711.7388-9-david@craven.ch> (David Craven's message
	of "Thu, 1 Sep 2016 17:57:11 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> skribis:

> * gnu/packages/wayland.scm (weston): New file.
> * gnu/local.mk (GNU_PACKAGE_MODULES): Add it.

[...]

> +(define-public cairo-xcb
> +  (package
> +    (inherit cairo)
> +    (name "cairo-xcb")
> +    (inputs
> +     `(("mesa" ,mesa)
> +       ,@(package-inputs cairo)))
> +    (arguments
> +     `(#:tests? #f
> +       #:configure-flags
> +       '("--enable-xlib-xcb" "--enable-gl" "--enable-egl")))))

Probably this should be kept next to =E2=80=98cairo=E2=80=99, and added as =
a separate
patch.  Also please change the synopsis to something like =E2=80=9C2D graph=
ics
library (with X11 support)=E2=80=9D.

> +(define-public xwayland
> +  (package
> +    (inherit xorg-server)
> +    (name "xwayland")

Should it be =E2=80=9Cxorg-server-xwayland=E2=80=9D, since fundamentally it=
=E2=80=99s still the
=E2=80=9Cxorg-server=E2=80=9D source?

> +    (inputs
> +     `(("libepoxy" ,libepoxy)
> +       ("wayland" ,wayland)
> +       ,@(package-inputs xorg-server)))
> +    (arguments
> +      (substitute-keyword-arguments (package-arguments xorg-server)
> +        ((#:configure-flags flags)
> +         `(cons* "--enable-xwayland" "--disable-xorg"
> +                 "--disable-docs"    "--disable-devel-docs"
> +                 "--disable-xvfb"    "--disable-xnest"
> +                 "--disable-xquartz" "--disable-xwin"
> +                 ,flags))))))

Please add a synopsis (as above).

> +(define-public weston
> +  (package
> +    (name "weston")
> +    (version "1.11.0")

[...]

> +    (synopsis "Reference implementation of a Wayland compositor")

What about =E2=80=9CReference Wayland graphical display server=E2=80=9D?

> +    (description "Weston is the reference implementation of a Wayland
> +compositor, and a useful compositor in its own right.")

Maybe add a sentence about what a Wayland compositor does.

Also I think people will prefer one patch per package.  :-)

Thank you!

Ludo=E2=80=99.