Re: [PATCH 0/2] Fix IBus input methods.

[Ricardo Wurmus <rekado@elephly.net>]

Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> Ricardo Wurmus <rekado@elephly.net> skribis:
>>>
>>>> 宋文武 <iyzsong@member.fsf.org> writes:
>>>>
>>>>> Ricardo Wurmus <rekado@elephly.net> writes:
>>>>>
>>>>>>   gnu: gtk+-2: Add patch to support GUIX_GTK2_IM_MODULE_FILE.
>>>>>>   gnu: gtk+: Add patch to support GUIX_GTK3_IM_MODULE_FILE.
>>>>>
>>>>> Look good to me!
>>>>
>>>> Thanks!
>>>>
>>>> What do you think: should this be a separate branch (e.g. “gtk-rebuild”)
>>>> or should it be pushed to “core-updates”?
>>>
>>> As discussed on IRC, I’ve added a “jobset”:
>>>
>>>   https://hydra.gnu.org/jobset/gnu/gtk-im-modules
>>>
>>> There seems to be only 1 new failure compared to ‘master’:
>>>
>>>   https://hydra.gnu.org/eval/109124?compare=master#tabs-now-fail
>>>
>>> Could you take a look?
>>
>> This looks unrelated to me.
>
> OK.
>
>>> We’ll have to merge ‘master’ into it and evaluate it again.
>>
>> Can “gtk-im-modules” not be merged into the master branch directly?
>
> One benefit of having a separate jobset is that we can wait until
> everything is built before merging to master.  The problem here is that
> this branch was entirely built several days ago, so it might be somewhat
> outdated now.

I understand.

> Thus, could you either (1) merge locally into master and make sure no
> important binaries are missing (try “guix build emacs -n” or similar),
> and if that is the case, you can push; or (2) merge master into
> gtk-im-modules and reevaluate the jobset?

I tried with “emacs”, “icecat”, “epiphany”, “ardour”, “gnome-desktop”,
“libgnomeui”, and “libxfce4ui” — all of them only report that they would
download substitutes.  None report that anything would need to be built
locally.

So, I’ll go ahead and merge “gtk-im-modules” into “master” and push to
master in a few minutes.

~~ Ricardo