From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH 1/2] gnu: gnunet: Add inputs. Date: Mon, 19 Sep 2016 15:17:33 +0000 Message-ID: <874m5bzzoy.fsf@we.make.ritual.n0.is> References: <20160916134921.17987-1-ng0@we.make.ritual.n0.is> <8737kwm2y5.fsf@elephly.net> <87zin42c94.fsf@we.make.ritual.n0.is> <87wpi8kkvf.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bm0KK-0003Co-JQ for guix-devel@gnu.org; Mon, 19 Sep 2016 11:17:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bm0KE-00015h-Ed for guix-devel@gnu.org; Mon, 19 Sep 2016 11:17:47 -0400 Received: from aibo.runbox.com ([91.220.196.211]:34426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bm0KE-00014X-7i for guix-devel@gnu.org; Mon, 19 Sep 2016 11:17:42 -0400 In-Reply-To: <87wpi8kkvf.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org Ricardo Wurmus writes: > ng0 writes: > >>> Is adding “bluez” and “libogg” really needed? They seem a little >>> unusual for networking software. >> >> It is not just networking software. >> It's been to long since I found out all these dependencies, I just >> decided to add them to guix master now. Bluez is for bluetooth support >> of whatever feature (look it up in either documentation or the >> Makefile), libogg is needed for audio playback I think. I could be wrong >> about this one. You know, the longer you work on something the more you >> find and without comments it all gets obscure. But I really think libogg >> in addition to libopus is for something audio related. > > Well, that’s why I’m asking as I don’t have time to investigate the > reasons for the suggested changes myself. I know what “bluez” and > “libogg” do, but it’s a bit odd to have them as dependencies of GNUnet. GNUnet has the ability to create an adhoc meshnetwork over bluetooth if I remember correctly. I'll ask christian again, I never used this part. greping gets you this: ABOUT-NLS:157: bluez-pin | [] [] | ABOUT-NLS:341: bluez-pin | [] [] [] [] [] [] | ABOUT-NLS:525: bluez-pin | [] [] [] [] [] [] [] [] | ABOUT-NLS:709: bluez-pin | [] [] [] [] [] | ABOUT-NLS:893: bluez-pin | [] [] [] [] [] [] [] [] | ABOUT-NLS:1077: bluez-pin | [] [] [] [] [] [] [] [] | 37 src/transport/gnunet-helper-transport-bluetooth.c:100: * In bluez library, the maximum name length of a device is 8 Which is why I have to ask about this. > > GNUnet doesn’t encode/decode ogg audio files, does it? It has this telephony feature (gnunet-conversation, despite the README it no longer is experimental) and gnunet-helper-audio-record-gst references ogg. src/conversation/gnunet-helper-audio-record.c:41:#include configure.ac:424:# libogg configure.ac:425:AC_CHECK_LIB(ogg, ogg_stream_flush_fill, configure.ac:426: [AC_CHECK_HEADERS([ogg/ogg.h], configure.ac:428: ogg=1 configure.ac:429: AC_DEFINE(HAVE_OGG,1,[Have ogg]), configure.ac:431: ogg=0 configure.ac:432: AC_DEFINE(HAVE_OGG,0,[lacking ogg]))], configure.ac:434: ogg=0) >> If you think comments are needed because someone in the future could >> decide to cut down the "bloat", I can comment all the dependencies with >> which part of GNUnet needs them. > > Commenting unusual inputs should be enough. > > ~~ Ricardo > > -- ng0