From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH v2] gnu: Add sunxi-tools. Date: Tue, 04 Oct 2016 11:19:14 +0200 Message-ID: <874m4scvzh.fsf@gnu.org> References: <20161002115401.2bea3797@scratchpost.org> <20161002095836.6495-1-dannym@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brLsh-0002wc-23 for guix-devel@gnu.org; Tue, 04 Oct 2016 05:19:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brLsb-00038X-JL for guix-devel@gnu.org; Tue, 04 Oct 2016 05:19:21 -0400 In-Reply-To: <20161002095836.6495-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Sun, 2 Oct 2016 11:58:36 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org Danny Milosavljevic skribis: > * gnu/packages/admin.scm (sunxi-tools): New variable. > --- > gnu/packages/admin.scm | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm > index 6981242..06c552f 100644 > --- a/gnu/packages/admin.scm > +++ b/gnu/packages/admin.scm > @@ -1846,3 +1846,35 @@ Kerberos and Heimdal and FAST is supported with re= cent MIT Kerberos.") > (license license:gpl1+))) >=20=20 > ;;http://archives.eyrie.org/software/kerberos/pam-krb5-4.7.tar.xz > + > +(define-public sunxi-tools > + (package > + (name "sunxi-tools") > + (version "1.3") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://github.com/linux-sunxi/" > + "sunxi-tools/archive/v" version ".tar.gz")) > + (sha256 > + (base32 "1iazm28gws1i8sls3gxwc5p108n56ags287zmh1rpvkn2k1az81a")) > + (modules '((guix build utils))) > + (snippet > + ;; Source is included anyway. > + '(delete-file-recursively "bin")))) The comment should rather be =E2=80=9CRemove binaries contained in the tarb= all.=E2=80=9D > + (native-inputs > + `(("pkg-config" ,pkg-config))) > + (inputs > + `(("libusb" ,libusb))) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f ; no tests exist > + #:make-flags (list (string-append "PREFIX=3D" > + (assoc-ref %outputs "out"))) > + #:phases > + (modify-phases %standard-phases > + (delete 'configure)))) > + (home-page "https://github.com/linux-sunxi/sunxi-tools") > + (synopsis "Tools to help manage Allwinner A10 devices") > + (description "This package contains tools for Allwinner A10 devices = (for FEX, FEL USB, PIO, NAND, JTAG, RAM)") I don=E2=80=99t understand this description. Since =E2=80=9CTools=E2=80=9D= , =E2=80=9Cmanage=E2=80=9D, and =E2=80=9Cdevices=E2=80=9D could mean anything, could you add qualifiers to = give more context, like: =E2=80=9CFrobbing tools for Allwinner A10 foobar devices=E2=80=9D and similarly expound the description (with a period at the end of the sentence)? Based on that, we might device that admin.scm is not the best fit for this package. Maybe flashing-tools.scm? Could you send an updated patch? Thanks in advance! Ludo=E2=80=99.