Re: [PATCH 1/4] gnu: Add x265.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1764 bytes --]

Efraim Flashner <efraim@flashner.co.il> writes:

> * gnu/packages/video.scm (x265): New variable.
> ---
>  gnu/packages/video.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index bd82eb8..6000c5b 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -250,6 +250,34 @@ H.264 (MPEG-4 AVC) video streams.")
>                      "file://extras/cl.h"
>                      "See extras/cl.h in the distribution.")))))
>  
> +(define-public x265
> +  (package
> +    (name "x265")
> +    (version "2.1")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "https://download.videolan.org/videolan/x265/"
> +                            "x265_" version ".tar.gz"))
> +        (sha256
> +         (base32
> +          "0hx6sr9l7586gs4qds2sj0i1m5brxkaqq3cwmibhfb559fpvkz48"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f ; tests are skipped if cpu-optimized code isn't built
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'prepare-build
> +           (lambda _
> +             (delete-file-recursively "build")
> +             (chdir "source")
> +             #t)))))
> +    (home-page "http://x265.org/")
> +    (synopsis "Library for encoding h.265/HEVC video streams")
> +    (description "x265 is a H.265 / HEVC video encoder application library,
> +designed to encode video or images into an H.265 / HEVC encoded bitstream.")
> +    (license license:gpl2+)))

The files in compat/getopt/ are lgpl2.1+. Unbundling it would be even
better, if possible.

Other than that this LGTM!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]