From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roel Janssen <roel@gnu.org>
Subject: Re: [PATCH 11/16] gnu: Add python-notebook.
Date: Tue, 01 Nov 2016 19:10:51 +0100
Message-ID: <874m3roytw.fsf@gnu.org>
References: <20161101122046.751-1-ricardo.wurmus@mdc-berlin.de>
	<20161101122046.751-12-ricardo.wurmus@mdc-berlin.de>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58167)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <roel@gnu.org>) id 1c1dWC-0000FK-2q
	for guix-devel@gnu.org; Tue, 01 Nov 2016 14:10:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <roel@gnu.org>) id 1c1dV6-0001N4-CS
	for guix-devel@gnu.org; Tue, 01 Nov 2016 14:10:40 -0400
In-reply-to: <20161101122046.751-12-ricardo.wurmus@mdc-berlin.de>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org


Ricardo Wurmus writes:

> * gnu/packages/python.scm (python-notebook, python2-notebook): New
> variables.
> ---
>  gnu/packages/python.scm | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 4463f50..bd04c80 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -6819,6 +6819,44 @@ convert an @code{.ipynb} notebook file into various static formats including:
>  (define-public python2-nbconvert
>    (package-with-python2 python-nbconvert))
>  
> +(define-public python-notebook
> +  (package
> +    (name "python-notebook")
> +    (version "4.2.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (pypi-uri "notebook" version))
> +              (sha256
> +               (base32
> +                "0laq5c2f21frq6xcdckgq7raqhznbjb0qs0357g612z87wyn1a9r"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda _
> +             ;; HOME must be set for tests
> +             (setenv "HOME" "/tmp")
> +             (zero? (system* "nosetests")))))))
> +    (propagated-inputs
> +     `(("python-jupyter-core" ,python-jupyter-core)
> +       ("python-nbformat" ,python-nbformat)
> +       ("python-nbconvert" ,python-nbconvert)
> +       ("python-ipython" ,python-ipython)))
> +    (native-inputs
> +     `(("python-nose" ,python-nose)
> +       ("python-sphinx" ,python-sphinx)
> +       ("python-requests" ,python-requests)))
> +    (home-page "http://jupyter.org/")
> +    (synopsis "Web-based notebook environment for interactive computing")
> +    (description
> +     "The Jupyter HTML notebook is a web-based notebook environment for
> +interactive computing.")
> +    (license license:bsd-3)))
> +
> +(define-public python2-notebook
> +  (package-with-python2 python-notebook))
> +
>  (define-public python-chardet
>    (package
>      (name "python-chardet")

LGTM!

Kind regards,
Roel Janssen