From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: [PATCH] gnu: Add Prosody service. Date: Sun, 08 Jan 2017 20:06:19 +0100 Message-ID: <874m19qslw.fsf@lassieur.org> References: <20170104215559.3295-1-clement@lassieur.org> <874m1azhi4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQInY-0008JA-AL for guix-devel@gnu.org; Sun, 08 Jan 2017 14:06:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQInV-000614-6G for guix-devel@gnu.org; Sun, 08 Jan 2017 14:06:32 -0500 In-reply-to: <874m1azhi4.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org > I would suggest moving the gnu/packages change to a separate patch, but > apart from that I don=E2=80=99t have anything to add to Hartmut=E2=80=99= s comment. > > Could you send updated patches? Here they are. > I suppose you confirmed with =E2=80=98guix system vm=E2=80=99 or simila= r that it works > as intended. Could you consider writing a system test for Prosody? Th= e > (gnu tests mail) and (gnu tests ssh) modules provide relatively simple > examples to start from. It works on my GuixSD server. I'll start to write a system test. Thank you all for the review!