From mboxrd@z Thu Jan 1 00:00:00 1970 From: "ng0" Subject: Re: [PATCH 3/7] gnu: Add python2-ruamel.ordereddict Date: Thu, 02 Feb 2017 10:13:46 +0000 Message-ID: <874m0c7vdx.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> References: <20160925173931.GD9499@jasmine> <20170131125339.18500-1-contact.ng0@cryptolab.net> <20170131125339.18500-4-contact.ng0@cryptolab.net> <87h94d9os5.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZENN-00024C-5p for guix-devel@gnu.org; Thu, 02 Feb 2017 05:12:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZENJ-0000cR-Ug for guix-devel@gnu.org; Thu, 02 Feb 2017 05:12:25 -0500 Received: from perdizione.investici.org ([94.23.50.208]:47264) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cZENJ-0000bQ-Oa for guix-devel@gnu.org; Thu, 02 Feb 2017 05:12:21 -0500 In-reply-to: <87h94d9os5.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Maxim Cournoyer Cc: guix-devel@gnu.org Hi, Maxim Cournoyer writes: > Hi, > > I have a few of comments for this one too. > > contact.ng0@cryptolab.net writes: > >> From: ng0 >> >> * gnu/packages/python.scm (python2-ruamel.ordereddict): New variable. >> --- >> gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm >> index f6516d26b..cef9d2a8c 100644 >> --- a/gnu/packages/python.scm >> +++ b/gnu/packages/python.scm >> @@ -583,6 +583,34 @@ the Python logging module that outputs records using terminal colors.") >> (native-inputs >> `(("python2-setuptools" ,python2-setuptools)))))) >> >> +(define-public python2-ruamel.ordereddict >> + (package >> + (name "python2-ruamel.ordereddict") >> + (version "0.4.9") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (pypi-uri "ruamel.ordereddict" version)) >> + (sha256 >> + (base32 >> + "1xmkl8v9l9inm2pyxgc1fm5005yxm7fkd5gv74q7lj1iy5qc8n3h")))) >> + (build-system python-build-system) >> + ;; XXX: https://bitbucket.org/ruamel/ordereddict/issues/2 > > Maybe the comment should say "No ordereddict python3 build available" ? > >> + (arguments >> + `(#:python ,python-2)) >> + (inputs >> + `(("python2-setuptools" ,python2-setuptools))) > > Unnecessary, part of our Python2 package. Yes, as I wrote I did not review it again. This is from back in September, before the build system was changed. I forgot about tinycm in the list-email: This is dropped too. I have no way to fix this. The patches will still apply (rebased on master), so anyone who wants to fix this can fix these python packages. >> + (home-page "https://bitbucket.org/ruamel/ordereddict") >> + (synopsis "Version of @code{dict} that keeps keys in insertion >> +resp. sorted order") >> + (description >> + "This is an implementation of an ordered dictionary with Key >> +Insertion Order and Key Value Insertion Order. The standard library > > Is the capitalization of Key Insertion Order/Key Value Insertion Order > really necessary? Also, there are 2 spaces following the period. > >> +module OrderedDict, implemented later, implements a subset of >> +ordereddict functionality. Sorted dictionaries are also provided. > > 2 spaces following the period here also. Is this intended? > >> +Currently only with Key Sorted Order.") > > Again, I'm not sure about the proper capitalization here. > > Thanks, > > Maxim -- ng0 . https://www.inventati.org/patternsinthechaos/