From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build Date: Fri, 24 Feb 2017 17:13:53 -0500 Message-ID: <874lzjb5jy.fsf@netris.org> References: <20170218004427.12392-1-huang_ying_caritas@163.com> <87tw7jn4mo.fsf@163.com> <20170224150256.641cb08d@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1chO9I-0006TI-Rz for guix-devel@gnu.org; Fri, 24 Feb 2017 17:15:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1chO9F-0006X0-OX for guix-devel@gnu.org; Fri, 24 Feb 2017 17:15:36 -0500 Received: from world.peace.net ([50.252.239.5]:39531) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1chO9F-0006RX-KQ for guix-devel@gnu.org; Fri, 24 Feb 2017 17:15:33 -0500 In-Reply-To: <20170224150256.641cb08d@scratchpost.org> (Danny Milosavljevic's message of "Fri, 24 Feb 2017 15:02:56 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org, Alex Kost Danny Milosavljevic writes: > yeah, I've looked at it and I see what you are trying to do. > > You modified 'union to replicate the directory tree and symlink only > the non-directory files - in order to be able to add "fonts.dir" in > those directories. If the purpose here is to facilitate mutating anything in the store, then we cannot accept this. The entire design is Guix is based on store items being immutable, and we assume this throughout the code, most notably by assuming that store items and parts of store items can be aliased instead of copied. If you want to add something to your profile, e.g. fonts.dir, then use profile hooks for that. See %default-profile-hooks in guix/profiles.scm. However, we already have a hook to build fonts.dir, so I'm not sure what's missing here. If we've misunderstood the rationale for this patch, can you help us understand what you're trying to do? Thanks, Mark