all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org, Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build
Date: Fri, 24 Feb 2017 17:13:53 -0500	[thread overview]
Message-ID: <874lzjb5jy.fsf@netris.org> (raw)
In-Reply-To: <20170224150256.641cb08d@scratchpost.org> (Danny Milosavljevic's message of "Fri, 24 Feb 2017 15:02:56 +0100")

Danny Milosavljevic <dannym@scratchpost.org> writes:

> yeah, I've looked at it and I see what you are trying to do.
>
> You modified 'union to replicate the directory tree and symlink only
> the non-directory files - in order to be able to add "fonts.dir" in
> those directories.

If the purpose here is to facilitate mutating anything in the store,
then we cannot accept this.  The entire design is Guix is based on store
items being immutable, and we assume this throughout the code, most
notably by assuming that store items and parts of store items can be
aliased instead of copied.

If you want to add something to your profile, e.g. fonts.dir, then use
profile hooks for that.  See %default-profile-hooks in
guix/profiles.scm.  However, we already have a hook to build fonts.dir,
so I'm not sure what's missing here.

If we've misunderstood the rationale for this patch, can you help us
understand what you're trying to do?

     Thanks,
       Mark

  reply	other threads:[~2017-02-24 22:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-18  0:44 [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build huang_ying_caritas
2017-02-18  0:44 ` [PATCH 2/2] guix: profiles: create fonts.dir/scale for all fonts directories huang_ying_caritas
2017-02-24 12:40 ` [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build Huang, Ying
2017-02-24 13:32   ` Andy Wingo
2017-02-25  1:03     ` Huang, Ying
2017-02-24 14:02   ` Danny Milosavljevic
2017-02-24 22:13     ` Mark H Weaver [this message]
2017-02-25 12:43       ` Huang, Ying
2017-02-27  9:06       ` Danny Milosavljevic
2017-03-03  1:25         ` Mark H Weaver
2017-02-25  1:05     ` Huang, Ying
2017-02-25 12:30     ` Huang, Ying
2017-02-26  8:23       ` 宋文武
2017-02-27 11:27         ` Huang, Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lzjb5jy.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=alezost@gmail.com \
    --cc=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.