From: ludo@gnu.org (Ludovic Courtès)
To: "Clément Lassieur" <clement@lassieur.org>
Cc: 26462@debbugs.gnu.org
Subject: bug#26462: [PATCH 1/2] gnu: icu4c: Fix crashes in programs using system ICU.
Date: Fri, 14 Apr 2017 17:18:30 +0200 [thread overview]
Message-ID: <874lxrdnll.fsf@gnu.org> (raw)
In-Reply-To: <87a87jm3vi.fsf@lassieur.org> ("Clément Lassieur"'s message of "Fri, 14 Apr 2017 16:59:45 +0200")
Clément Lassieur <clement@lassieur.org> skribis:
> Clément Lassieur <clement@lassieur.org> writes:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> Clément Lassieur <clement@lassieur.org> skribis:
>>>
>>>> * gnu/packages/patches/icu4c-reset-keyword-list-iterator.patch: New file.
>>>> * gnu/local.mk (dist_patch_DATA): Add it.
>>>> * gnu/packages/icu4c.scm (icu4c)[source]: Use it.
>>>
>>> [...]
>>>
>>>> +++ b/gnu/packages/patches/icu4c-reset-keyword-list-iterator.patch
>>>> @@ -0,0 +1,128 @@
>>>> +Copied from upstream: http://bugs.icu-project.org/trac/changeset/39484/.
>>>> +
>>>> +Paths and line endings have been adapted.
>>>
>>> Woow, good catch!
>>>
>>> 1,700 packages depend on icu4c so the update would have to go to
>>> ‘core-updates’, but that won’t be merged until several weeks.
>>>
>>> For ‘master’, in the meantime, I see two solutions:
>>>
>>> 1. If the bug only affects specific applications, we could add an
>>> icu4c variant and use that only where needed (icecat, 0ad, etc.).
>>>
>>> 2. If the bug manifests itself pervasively we could graft it in
>>> ‘master’ (I guess it’s ABI-compatible, right?).
>>>
>>> Thoughts?
>>
>> I prefer the second solution, in case the bug appears in other
>> applications as well, and I think it is ABI-compatible. I just sent the
>> patch for the graft in master. I'll do the patch for core-updates
>> later, when master is merged into it.
>
> But I might be wrong :) If you think the first solution is better,
> don't hesitate to tell me, I'll do another patch.
No no, I trust you! I mean, making a graft in master is the safest
approach anyway.
Ludo’.
next prev parent reply other threads:[~2017-04-14 15:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 10:48 bug#26462: Fix crashes in programs using system ICU Clément Lassieur
2017-04-12 10:53 ` bug#26462: [PATCH 1/2] gnu: icu4c: " Clément Lassieur
2017-04-12 10:53 ` bug#26462: [PATCH 2/2] gnu: icecat: Use " Clément Lassieur
2017-04-12 11:51 ` bug#26462: [PATCH 1/2] gnu: icu4c: Fix crashes in programs using " Ludovic Courtès
2017-04-14 14:51 ` bug#26462: [PATCH] " Clément Lassieur
2017-04-16 9:54 ` Ludovic Courtès
2017-04-17 18:45 ` Clément Lassieur
2017-04-14 14:55 ` bug#26462: [PATCH 1/2] " Clément Lassieur
2017-04-14 14:59 ` Clément Lassieur
2017-04-14 15:18 ` Ludovic Courtès [this message]
2017-04-12 10:55 ` bug#26462: " Clément Lassieur
2017-04-12 11:22 ` ng0
2017-04-12 11:31 ` Clément Lassieur
2017-04-12 11:42 ` Clément Lassieur
2017-04-12 11:53 ` ng0
2017-04-13 22:53 ` Clément Lassieur
2017-04-12 11:47 ` ng0
2017-04-13 23:01 ` Clément Lassieur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lxrdnll.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=26462@debbugs.gnu.org \
--cc=clement@lassieur.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.