From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40633)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d3QJN-0007nz-Ee
	for guix-patches@gnu.org; Wed, 26 Apr 2017 13:01:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d3QJK-0002fN-DT
	for guix-patches@gnu.org; Wed, 26 Apr 2017 13:01:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:43721)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d3QJK-0002f6-7O
	for guix-patches@gnu.org; Wed, 26 Apr 2017 13:01:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d3QJJ-0000zq-Sr
	for guix-patches@gnu.org; Wed, 26 Apr 2017 13:01:01 -0400
Subject: bug#26669: [PATCH 1/7] gnu: Add cdrtools.
Resent-Message-ID: <handler.26669.B26669.14932260023681@debbugs.gnu.org>
References: <20170426.180534.1677459693482729603.post@thomasdanckaert.be>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <20170426.180534.1677459693482729603.post@thomasdanckaert.be>
Date: Wed, 26 Apr 2017 18:59:53 +0200
Message-ID: <874lxbdrzq.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Thomas Danckaert <post@thomasdanckaert.be>
Cc: 26669@debbugs.gnu.org


Hi Thomas,

Thanks for the patches !

Without going into details, it seems to me that you have indentation
issues in this serie.

> +(define-public cdrtools
> +  (package

>From here indentation is broken.

> +   (name "cdrtools")
> +   (version "3.01")
> +   (source (origin
> +             (method url-fetch)
> +             (uri (string-append
> +                   "mirror://sourceforge/cdrtools/cdrtools-" version ".tar.bz2"))
> +             (sha256
> +              (base32
> +               "03w6ypsmwwy4d7vh6zgwpc60v541vc5ywp8bdb758hbc4yv2wa7d"))
> +             (patches (search-patches "cdrtools-3.01-mkisofs-isoinfo.patch"))))
> +   (build-system gnu-build-system)
> +   (inputs
> +    `(("linux-headers" ,linux-libre-headers)))
> +   (native-inputs
> +    `(("coreutils" ,coreutils)))
> +   (arguments
> +    `(#:phases (modify-phases %standard-phases
> +                 (delete 'configure)
> +                 (add-before 'build 'set-linux-headers
> +                   (lambda _
> +                     (substitute* "autoconf/configure"
> +                       (("/usr/src/linux")
> +                        (assoc-ref %build-inputs "linux-headers")))
> +                     #t))
> +                 (add-before 'build 'substitute-dirs
> +                   (lambda _
> +                     (substitute* (append (find-files "DEFAULTS" "^Defaults\\.")
> +                                          (find-files "DEFAULTS_ENG" "^Defaults\\.")

Please keep all lines in *.scm files to 80 columns or less.

> +                                          (find-files "TEMPLATES" "^Defaults\\."))
> +                       (("/opt/schily") (assoc-ref %outputs "out")))
> +                     #t))

Thanks,

Mathieu