all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: doubleplusgood23@gmail.com (Ethan R. Jones)
To: ludo@gnu.org
Cc: 26934@debbugs.gnu.org
Subject: bug#26934: Re: bug#26934: [PATCH 1/3] gnu: video: add libzen
Date: Wed, 17 May 2017 19:47:47 -0400	[thread overview]
Message-ID: <874lwjt598.fsf@gmail.com> (raw)
In-Reply-To: <20170515025701.2492-1-doubleplusgood23@gmail.com>

<#secure method=pgp mode=sign>
Thanks for the response.
>> ---
>>  gnu/packages/video.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 42 insertions(+)

>Could you provide ChangeLog-style commit logs?  See ‘git log’ for
>examples and <https://gnu.org/s/guix/manual/html_node/Submitting-Patches.html>.

So I should independently `git add --patch` each addition, then do a multi-line
`git commit` like so:

    gnu: foo: Update to 1.0.
    
    * gnu/packages/foo.scm (foo): Update to 1.0
    * gnu/packages/foo.scm (libbar): New shared library.

>Could you squeeze that on one or two lines?

Is there a style on when to squeeze and when to not?

>Please double-check that this is needed.

Yup, all packages lack a proper configure script.

>Could you improve the synopsis and description

Do you have any ideas of what to add? I wasn't sure where to start
myself

Thanks!

dpg

  parent reply	other threads:[~2017-05-17 23:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15  2:56 bug#26934: [PATCH 1/3] gnu: video: add libzen Ethan R. Jones
2017-05-15  2:57 ` bug#26933: [PATCH 2/3] gnu: video: add libmediainfo Ethan R. Jones
2017-05-15  2:57 ` bug#26935: [PATCH 3/3] gnu: video: add mediainfo Ethan R. Jones
2017-05-17 13:20 ` bug#26934: [PATCH 1/3] gnu: video: add libzen Ludovic Courtès
2017-05-17 23:47 ` Ethan R. Jones [this message]
2017-05-18  9:04   ` Ludovic Courtès
2017-05-23 20:52 ` Ethan R. Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lwjt598.fsf@gmail.com \
    --to=doubleplusgood23@gmail.com \
    --cc=26934@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.