Re: Switching to Artifex Ghostscript

[Ricardo Wurmus <rekado@elephly.net>]

Leo Famulari <leo@famulari.name> writes:

> Here are patches that allow you build groff, cairo, and cups with the
> Artifex Ghostscript.

Woo!

> +        (patches (search-patches "artifex-ghostscript-runpath.patch"
> +                                 ;; TODO:
> +                                 ;;"ghostscript-CVE-2017-8291.patch"
> +                                 ))

What’s up with this?  Is the latest release of Artifex Ghostscript
vulnerable?

> +        (modules '((guix build utils)))
> +        (snippet
> +          ;; Remove bundled libraries.
> +          ;; TODO Try unbundling ijs, which is developed alongside Ghostscript.
> +         '(begin
> +            (for-each delete-file-recursively '("freetype" "jbig2dec" "jpeg"
> +                                                "lcms2" "libpng"
> +                                                ;;"openjpeg" ; Patched fork.
> +                                                "tiff" "zlib"))))))

Excellent!

> +         (replace 'build
> +           (lambda _
> +             ;; Build 'libgs.so', but don't build the statically-linked 'gs'
> +             ;; binary (saves 22 MiB).
> +             (zero? (system* "make" "so" "-j"
> +                             (number->string
> (parallel-job-count))))))

Couldn’t we just add “#:make-flags '("so")” and avoid replacing the
build phase?


> From 8ee8b63f35909ca1b9cfd89552f08e22f28b5d10 Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo@famulari.name>
> Date: Mon, 29 May 2017 04:42:37 -0400
> Subject: [PATCH 2/3] gnu: ijs: Use modify-phases syntax.
>
> * gnu/packages/ghostscript.scm (ijs)[arguments]: Use modify-phases.

OK!

> From 35a515a7d2bbd95a45fde81b31201bd48a7e7588 Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo@famulari.name>
> Date: Mon, 29 May 2017 04:43:21 -0400
> Subject: [PATCH 3/3] gnu: ijs: Update to 9.21.0 and switch to Artifex
>  Ghostscript source.
>
> * gnu/packages/ghostscript.scm (ijs): Update to 9.21.0.
> [source, version, home-page]: Inherit from artifex-ghostscript.
> ---

LGTM!  Thank you!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net