From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMfIs-0004Ep-F3 for guix-patches@gnu.org; Sun, 18 Jun 2017 14:52:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMfIp-00079o-B4 for guix-patches@gnu.org; Sun, 18 Jun 2017 14:52:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:52720) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dMfIp-00079R-6G for guix-patches@gnu.org; Sun, 18 Jun 2017 14:52:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dMfIo-0005nq-Vh for guix-patches@gnu.org; Sun, 18 Jun 2017 14:52:02 -0400 Subject: [bug#27421] [PATCH 4/5] gnu: Add openttd-opengfx. Resent-Message-ID: From: Kei Kebreau References: <20170618174519.32747-1-kei@openmailbox.org> <20170618174519.32747-3-kei@openmailbox.org> <87fuexf92e.fsf@fastmail.com> Date: Sun, 18 Jun 2017 14:51:06 -0400 In-Reply-To: <87fuexf92e.fsf@fastmail.com> (Marius Bakke's message of "Sun, 18 Jun 2017 20:24:25 +0200") Message-ID: <874lvdcep1.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 27421@debbugs.gnu.org --=-=-= Content-Type: text/plain Marius Bakke writes: > Kei Kebreau writes: > >> * gnu/packages/games.scm (openttd-opengfx): New variable. > > [...] > >> + ;; Redirect stdout to /dev/null instead of stderr. This prevents >> + ;; dos2unix from receiving its version information as a flag. >> + (substitute* "Makefile" >> + (("\\$\\(UNIX2DOS\\) -q --version 2>/dev/null") >> + "$(UNIX2DOS) -q --version 1>/dev/null"))))) > > I'm a bit confused as to why this is necessary. I guess it's a behavior > change in recent versions, that --version prints on stdout? LGTM anyway. > I haven't used old versions of dos2unix, so I wouldn't know better. I've rephrased the comment to make it a bit clearer. >> + ;; The check phase for this package only checks the md5sums of the >> built >> + ;; GRF files against the md5sums of the release versions. Because >> we use >> + ;; different software versions than upstream does, some of the md5sums >> + ;; are different. However, the package is still reproducible, it's >> safe >> + ;; to disable this test. >> + #:tests? #f)) >> + (native-inputs `(("dos2unix" ,dos2unix) >> + ("gimp" ,gimp) >> + ("grfcodec" ,grfcodec) >> + ("nml" ,nml) >> + ("python" ,python-2))) >> + (home-page "http://dev.openttdcoop.org/projects/opengfx") >> + (synopsis "Base graphics set for OpenTTD") >> + (description >> + "The OpenGFX project is a free replacement of the base graphics so that >> +OpenTTD can be shipped finally fully functional without the need >> for additional >> +downloads.") > > Yay! I'm thinking we should mention this is one of many available > grahics sets for OpenTTD. Maybe something like.. > > "The OpenGFX projects is an implementation of the OpenTTD base grahics > set that aims to ensure the best possible out-of-the-box experience. > > OpenGFX provides you with... > @enumerate > @item All graphics you need to enjoy OpenTTD. > @item Uniquely drawn rail vehicles for every climate. > @item Completely snow-aware rivers. > @item Different river and sea water. > @item Snow-aware buoys. > @end enumerate" > > (Adapted from readme.ptxt) Why didn't I do this??? I'm totally using this description. > >> + (license license:gpl2))) > > Indeed version 2 only. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAllGy5oACgkQ5qXuPBlG eg0sEQ/+JPkCWJSTHGKGur4ast/wg37Ob0T9X4gSCLzepMXfEf0tXa8jl/5R6pIJ XFI5CsNOvquxXVrkrpt8wn40k/pWDIi5GWhc/uWxNmHNMhXYP2wktZSXJeQb5DmR 8OquOYAsJv7r5rTfe0VvuzpXgr/NN9BgR3TWTYRrBsC/A5weJkMQFy6DeMspUfGV 7c3iHR9Pa1l8Gzc5xEVeyZ7yL82vaObc3v6opVMnoz4xFrUMkjPcBTek0yLayU1A ElDaoEmzJh/OIu3Jo2g2Ep+DKSvlx8CJ379YTG7fSVbNcYycj7vg/uRtFmKXmqE5 uN8BEjj2jdQFApVG9Hwm6gp6/1gy1ZA8V9wzd7eiMymLKkkzJqokgqI0O3zSQ3td ImtEBg+uBDxe9/Xe+lDkhk2vmHJaxdUvHgODGLMVt3c+QLXKhnbS9ugwFbvx+N7m YqOBVNJBH1U2DogvEMy1pnVn+cWu+tKM/esEpSkp2CGOvpcb3HVW/G016M9H1HIG cWVTCrKE3HPpYL2e4k26acpiR0ffS+eXiAjT67dw3FKGlJOxpMkoqVJgcXFZTuit tEFMJCWiJONk8ZgjM5Fc75D6NJdMBP3Rz7CLXQQIRCzphnEuNK0sO3ex9AxWDsep Oe5R8xmSkQFACFQzBrEEbYBaFNme6FmfkZMp7Z7bLJot3msee0I= =9Ag8 -----END PGP SIGNATURE----- --=-=-=--