Marius Bakke <mbakke@fastmail.com> writes:

> Kei Kebreau <kei@openmailbox.org> writes:
>
>> * gnu/packages/games.scm (openttd-opengfx): New variable.
>
> [...]
>
>> +             ;; Redirect stdout to /dev/null instead of stderr. This prevents
>> +             ;; dos2unix from receiving its version information as a flag.
>> +             (substitute* "Makefile"
>> +               (("\\$\\(UNIX2DOS\\) -q --version 2>/dev/null")
>> +                "$(UNIX2DOS) -q --version 1>/dev/null")))))
>
> I'm a bit confused as to why this is necessary. I guess it's a behavior
> change in recent versions, that --version prints on stdout? LGTM anyway.
>

I haven't used old versions of dos2unix, so I wouldn't know better. I've
rephrased the comment to make it a bit clearer.

>> + ;; The check phase for this package only checks the md5sums of the
>> built
>> + ;; GRF files against the md5sums of the release versions. Because
>> we use
>> +       ;; different software versions than upstream does, some of the md5sums
>> + ;; are different. However, the package is still reproducible, it's
>> safe
>> +       ;; to disable this test.
>> +       #:tests? #f))
>> +    (native-inputs `(("dos2unix" ,dos2unix)
>> +                     ("gimp" ,gimp)
>> +                     ("grfcodec" ,grfcodec)
>> +                     ("nml" ,nml)
>> +                     ("python" ,python-2)))
>> +    (home-page "http://dev.openttdcoop.org/projects/opengfx")
>> +    (synopsis "Base graphics set for OpenTTD")
>> +    (description
>> +     "The OpenGFX project is a free replacement of the base graphics so that
>> +OpenTTD can be shipped finally fully functional without the need
>> for additional
>> +downloads.")
>
> Yay! I'm thinking we should mention this is one of many available
> grahics sets for OpenTTD. Maybe something like..
>
> "The OpenGFX projects is an implementation of the OpenTTD base grahics
> set that aims to ensure the best possible out-of-the-box experience.
>
> OpenGFX provides you with...
> @enumerate
> @item All graphics you need to enjoy OpenTTD.
> @item Uniquely drawn rail vehicles for every climate.
> @item Completely snow-aware rivers.
> @item Different river and sea water.
> @item Snow-aware buoys.
> @end enumerate"
>
> (Adapted from readme.ptxt)

Why didn't I do this???
I'm totally using this description.

>

>> +    (license license:gpl2)))
>
> Indeed version 2 only.