From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: 01/03: gnu: Add ncurses-with-gpm.
Date: Fri, 07 Jul 2017 13:14:39 +0200
Message-ID: <874luocxcw.fsf@gnu.org>
References: <20170707052643.30851.55219@vcs0.savannah.gnu.org>
	<20170707052644.03EDF20DD7@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48223)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1dTRDk-0004qd-Cw
	for guix-devel@gnu.org; Fri, 07 Jul 2017 07:14:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1dTRDf-0000JA-Dx
	for guix-devel@gnu.org; Fri, 07 Jul 2017 07:14:48 -0400
In-Reply-To: <20170707052644.03EDF20DD7@vcs0.savannah.gnu.org> (Danny
	Milosavljevic's message of "Fri, 7 Jul 2017 01:26:43 -0400 (EDT)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org

Heya Danny,

I=E2=80=99m really happy to see you continue John=E2=80=99s heroic work on =
the
installer!  I=E2=80=99ll be happy to give it a spin when you deem appropria=
te.

dannym@scratchpost.org (Danny Milosavljevic) skribis:

> commit 6b6c8317097482487c41f302a2ae4fc27d9220f0
> Author: Danny Milosavljevic <dannym@scratchpost.org>
> Date:   Fri Jul 7 07:07:51 2017 +0200
>
>     gnu: Add ncurses-with-gpm.
>=20=20=20=20=20
>     * gnu/packages/linux.scm (ncurses/gpm): New variable.

Side note:

> +(define-public ncurses/gpm
> +  (package
> +    (inherit ncurses)
> +    (name "ncurses-with-gpm")
> +    (arguments
> +        (substitute-keyword-arguments (package-arguments ncurses)
> +         ((#:configure-flags cf)
> +          `(cons (string-append "--with-gpm=3D" (assoc-ref %build-inputs=
 "gpm") "/lib/libgpm.so.2") ,cf))))
> +    (inputs
> +     `(("gpm" ,gpm)))))

Does it need the full file name of the .so?  Would be nicer if this
could be avoided, to avoid breakage in the future.

(BTW, please wrap lines to 80 chars.  :-))

Ludo=E2=80=99.