From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRtWX-00039z-OS for guix-patches@gnu.org; Thu, 21 Dec 2017 00:36:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRtWU-0003lo-J9 for guix-patches@gnu.org; Thu, 21 Dec 2017 00:36:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:36415) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eRtWU-0003lW-FH for guix-patches@gnu.org; Thu, 21 Dec 2017 00:36:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eRtWT-00006l-Mw for guix-patches@gnu.org; Thu, 21 Dec 2017 00:36:01 -0500 Subject: [bug#28832] [PATCH 1/3] gnu: Add emacs-json-reformat. In-Reply-To: <87lgke3vlz.fsf@gmail.com> Resent-Message-ID: From: Oleg Pykhalov References: <87lgke3vlz.fsf@gmail.com> <20171014102915.11778-1-go.wigust@gmail.com> <87y3o6uheo.fsf@gnu.org> <87d13yiw6w.fsf@gnu.org> <87609cluzf.fsf@gmail.com> <87zi6os3u3.fsf@gnu.org> <87fu8famhm.fsf@gmail.com> <877etofi3n.fsf@gmail.com> <87vah8hyxs.fsf@gnu.org> <87lghzyoyn.fsf@gmail.com> <878tdy1lmq.fsf@gmail.com> <87o9muxeo1.fsf@gmail.com> <87y3lxuk2x.fsf@gmail.com> Date: Thu, 21 Dec 2017 07:48:27 +0300 Message-ID: <874lokvg84.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alex Kost Cc: 28832@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Alex, Alex Kost writes: > Oleg Pykhalov (2017-12-20 06:26 +0300) wrote: >> Yes, because "geiser" differs from most of Emacs packages: >> >> ls >> /gnu/store/7rl2k8ismmyq9ic6ha6vzv38a3hrrni2-emacs-dash-2.13.0/share/emac= s/site-lisp/guix.d/dash-2.13.0/ >> dash-autoloads.el dash.el dash.elc dash-functional.el dash-funct= ional.elc >> >> ls /gnu/store/7lh77fmapmjjv3kj2q69dy58kjniw9am-geiser-0.9/share/emac= s/site-lisp/ >> geiser-autodoc.el geiser-chibi.elc =E2=80=A6 >> >> Maybe we just need to fix "geiser"? > > Sorry, I don't understand what you mean. What is wrong with geiser and > why/how should it be fixed? Elisp files of Geiser are in different place than others Emacs packages. There is no 'guix.d/geiser-0.9/'. (for-each (match-lambda =E2=80=A6) =E2=80=A6) in 'setup-environment' will f= ailed. Either we need to handle this case specific for Geiser or just change where it need to store Elisp files in 'geiser' package recipe. > Also do other non-"emacs-" packages (magit, emms) have the same problem? Hm, /gnu/store/k9zrrzpdw0mld0lqyackba3kwbw41ipr-emacs-emms-4.3/share/emacs/= site-lisp/ /gnu/store/zihybmvkccjb310fsxc2sad5j0w5vdi1-magit-2.11.0/share/emacs/st= ie-lisp/ it seems that it will be easier to handle a case without 'guix.d/PACKAGE-VERSION/'. But I don't see a way to determine is magit an Emacs package, because there is no "emacs-" prefix in "/gnu/store/=E2=80=A6-magit-2.11.0". 'emacs-inputs' will not help. See below. >>> I think we shouldn't rely on the assumption that all emacs inputs have >>> "emacs-" prefix >> >> Then, how to determine that a package is Emacs package? > > I don't know :-) 'emacs-inputs' is probably the best way. No :-), it only relies on "emacs-" prefix in store. emacs-inputs -> emacs-package? -> (string-prefix? "emacs-" name) >> emacs inputs contain "emacs-minimal" and "source". >> So we actually need to remove "emacs-minimal" instead "emacs". > > or maybe both? since some packages uses 'emacs' instead of > 'emacs-minimal' (emacs-auctex, emacs-exwm, etc.). Not both, because 'emacs-inputs' removes all inputs without "emacs-" prefix, so 'emacs' too. (emacs-inputs '(("emacs" . "/gnu/store/g1ldcr600kmdf2n1gsphk04hm30jr4bn-ema= cs-25.3") ("emacs-minimal" . "/gnu/store/p4smq1mw13lmpkdbs59d7w827hy7= mvgy-emacs-minimal-25.3"))) $3 =3D (("emacs-minimal" . "/gnu/store/p4smq1mw13lmpkdbs59d7w827hy7mvgy-ema= cs-minimal-25.3")) Thanks, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlo7PRsACgkQckbhHGm3 lWnwCA/+NZmVuc7RV+eqxRIHd/ldaAsSUmLHtocl0g1WqyJjmnfElnW2hVOXkaXl aerz5iVlsd2r4U3zEwvS9JSuxCS3ZvavZ22PCIvRuKaoGYDslYtSxM2hrdpxFnIr 5EZ56RaqPhvdhr/FPx2fTcLW6BNGnN1KfLYz9O2dsbWbnFvSaZ2JcADJteKnD8IY YTREVcPxqsZztbP8kU2B09kWz4gQi5wBjxZvtuIB9vlhOCthr68N/PxL8JtIc1uz wSKj1jAy1B1oc2NrXs/frkh1S3ZCfwDXvY7/kNFvcOcXi6IzsV3wRHr/0jsPujp/ s4FFPMLnP5ww5i7u6e9IYbddnbpeRWXAZNy/zWlJiHFnTk+EwIBSGPp3x9GflNY3 5SKTnFPWBb8eH/cjPvYuRWMxYY0kt9cQExtWHsgw9Mx7sEntcz/ZanGtfqFcCv8/ EQAciN9zjJ/+6647rf/oi4QE4rgXw9Hg/CqK5JHMtfNPr4pd4KYMatNBGhiKH/A3 +p/40hzpSNwlILSbVnHWB9hQ/WJ0XqesXB/QBi9ZVG+YtLeu0IrnxS124T0n7jEo 9N9zfmcK4eiN6t/epqsMc+NP7oY7NF8YwvuntTJpJJBmGZ51gxwEtM1zvHUMY32B /Ulv4i2PlEoOXNwbWpOmX1zWt8yDmjfvBV3K1rxLAV8wlBWepkA= =R4dm -----END PGP SIGNATURE----- --=-=-=--