[bug#30517] [PATCH] gnu: milkytracker: Actually link with the JACK library.

[bug#30517] [PATCH] gnu: milkytracker: Actually link with the JACK library.

[Kei Kebreau]

* gnu/packages/music.scm (milkytracker)[arguments]: Add appropriate configure
flag.
---
 gnu/packages/music.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 3709f10d1..e88c9f21f 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -2609,7 +2609,8 @@ of tools for manipulating and accessing your music.")
                     (("add_subdirectory\\(resources/music\\)") ""))))))
     (build-system cmake-build-system)
     (arguments
-     '(#:tests? #f)) ; no check target
+     '(#:tests? #f ; no check target
+       #:configure-flags '("-DCMAKE_CXX_FLAGS=-ljack")))
     (inputs
      `(("alsa-lib" ,alsa-lib)
        ("jack" ,jack-1)
-- 
2.16.1

[bug#30517] [PATCH] gnu: milkytracker: Actually link with the JACK library.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]

Kei Kebreau <kkebreau@posteo.net> writes:

> * gnu/packages/music.scm (milkytracker)[arguments]: Add appropriate configure
> flag.
> ---
>  gnu/packages/music.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 3709f10d1..e88c9f21f 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -2609,7 +2609,8 @@ of tools for manipulating and accessing your music.")
>                      (("add_subdirectory\\(resources/music\\)") ""))))))
>      (build-system cmake-build-system)
>      (arguments
> -     '(#:tests? #f)) ; no check target
> +     '(#:tests? #f ; no check target
> +       #:configure-flags '("-DCMAKE_CXX_FLAGS=-ljack")))
>      (inputs
>       `(("alsa-lib" ,alsa-lib)
>         ("jack" ,jack-1)

It should be noted that when I configure MilkyTracker to use JACK as an
audio driver, close the program, start the JACK server and open
MilkyTracker again, the MilkyTracker window appears black. When I drag
the window around on my desktop the program graphics flicker until I
stop dragging it, at which point it goes black again. Does anyone else
get this bug?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#30517] [PATCH] gnu: milkytracker: Actually link with the JACK library.

[Ludovic Courtès]

Kei Kebreau <kkebreau@posteo.net> skribis:

> * gnu/packages/music.scm (milkytracker)[arguments]: Add appropriate configure
> flag.
> ---
>  gnu/packages/music.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 3709f10d1..e88c9f21f 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -2609,7 +2609,8 @@ of tools for manipulating and accessing your music.")
>                      (("add_subdirectory\\(resources/music\\)") ""))))))
>      (build-system cmake-build-system)
>      (arguments
> -     '(#:tests? #f)) ; no check target
> +     '(#:tests? #f ; no check target
> +       #:configure-flags '("-DCMAKE_CXX_FLAGS=-ljack")))

I’d suggest adding a comment as to why this is needed.

Then I think you can go ahead and push it.  If it fixes a use case for
you, that’s already an improvement.

Thanks,
Ludo’.

bug#30517: [PATCH] gnu: milkytracker: Actually link with the JACK library.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

ludo@gnu.org (Ludovic Courtès) writes:

> Kei Kebreau <kkebreau@posteo.net> skribis:
>
>> * gnu/packages/music.scm (milkytracker)[arguments]: Add appropriate configure
>> flag.
>> ---
>>  gnu/packages/music.scm | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
>> index 3709f10d1..e88c9f21f 100644
>> --- a/gnu/packages/music.scm
>> +++ b/gnu/packages/music.scm
>> @@ -2609,7 +2609,8 @@ of tools for manipulating and accessing your music.")
>>                      (("add_subdirectory\\(resources/music\\)") ""))))))
>>      (build-system cmake-build-system)
>>      (arguments
>> -     '(#:tests? #f)) ; no check target
>> +     '(#:tests? #f ; no check target
>> +       #:configure-flags '("-DCMAKE_CXX_FLAGS=-ljack")))
>
> I’d suggest adding a comment as to why this is needed.
>
> Then I think you can go ahead and push it.  If it fixes a use case for
> you, that’s already an improvement.
>
> Thanks,
> Ludo’.

Pushed with added comment. Thanks for reviewing!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]